fix(tempo): queryEnabled not needed with grafana integration (#1011) #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes Rendered ChartOnly in out/target/tempo/values-k3d.yaml/sx-tempo/charts/tempo/templates: configmap-tempo-query.yaml
diff -U 4 -r out/target/tempo/values-k3d.yaml/sx-tempo/charts/tempo/templates/service.yaml out/pr/tempo/values-k3d.yaml/sx-tempo/charts/tempo/templates/service.yaml
--- out/target/tempo/values-k3d.yaml/sx-tempo/charts/tempo/templates/service.yaml 2025-01-24 19:47:35.947623794 +0000
+++ out/pr/tempo/values-k3d.yaml/sx-tempo/charts/tempo/templates/service.yaml 2025-01-24 19:47:02.091264819 +0000
@@ -25,15 +25,8 @@
- name: tempo-prom-metrics
port: 3100
protocol: TCP
targetPort: 3100
- - name: jaeger-metrics
- port: 16687
- protocol: TCP
- targetPort: 16687
- - name: tempo-query-jaeger-ui
- port: 16686
- targetPort: 16686
- name: tempo-jaeger-thrift-http
port: 14268
protocol: TCP
targetPort: 14268
diff -U 4 -r out/target/tempo/values-k3d.yaml/sx-tempo/charts/tempo/templates/statefulset.yaml out/pr/tempo/values-k3d.yaml/sx-tempo/charts/tempo/templates/statefulset.yaml
--- out/target/tempo/values-k3d.yaml/sx-tempo/charts/tempo/templates/statefulset.yaml 2025-01-24 19:47:35.947623794 +0000
+++ out/pr/tempo/values-k3d.yaml/sx-tempo/charts/tempo/templates/statefulset.yaml 2025-01-24 19:47:02.091264819 +0000
@@ -85,35 +85,15 @@
- mountPath: /conf
name: tempo-conf
- mountPath: /tmp
name: tmp
- - args:
- - --query.base-path=/
- - --grpc-storage-plugin.configuration-file=/conf/tempo-query.yaml
- image: grafana/tempo-query:2.7.0
- imagePullPolicy: IfNotPresent
- name: tempo-query
- ports:
- - containerPort: 16686
- name: jaeger-ui
- - containerPort: 16687
- name: jaeger-metrics
- env:
- resources:
- {}
- volumeMounts:
- - mountPath: /conf
- name: tempo-query-conf
securityContext:
fsGroup: 10001
runAsGroup: 10001
runAsNonRoot: true
runAsUser: 10001
volumes:
- configMap:
- name: tempo-query
- name: tempo-query-conf
- - configMap:
name: tempo
name: tempo-conf
- name: tmp
emptyDir: {} |
Changes Default Values |
Changes Rendered ChartOnly in out/target/tempo/values-k3d.yaml/sx-tempo/charts/tempo/templates: configmap-tempo-query.yaml
diff -U 4 -r out/target/tempo/values-k3d.yaml/sx-tempo/charts/tempo/templates/service.yaml out/pr/tempo/values-k3d.yaml/sx-tempo/charts/tempo/templates/service.yaml
--- out/target/tempo/values-k3d.yaml/sx-tempo/charts/tempo/templates/service.yaml 2025-01-24 20:46:26.361377992 +0000
+++ out/pr/tempo/values-k3d.yaml/sx-tempo/charts/tempo/templates/service.yaml 2025-01-24 20:45:48.023545597 +0000
@@ -25,15 +25,8 @@
- name: tempo-prom-metrics
port: 3100
protocol: TCP
targetPort: 3100
- - name: jaeger-metrics
- port: 16687
- protocol: TCP
- targetPort: 16687
- - name: tempo-query-jaeger-ui
- port: 16686
- targetPort: 16686
- name: tempo-jaeger-thrift-http
port: 14268
protocol: TCP
targetPort: 14268
diff -U 4 -r out/target/tempo/values-k3d.yaml/sx-tempo/charts/tempo/templates/statefulset.yaml out/pr/tempo/values-k3d.yaml/sx-tempo/charts/tempo/templates/statefulset.yaml
--- out/target/tempo/values-k3d.yaml/sx-tempo/charts/tempo/templates/statefulset.yaml 2025-01-24 20:46:26.361377992 +0000
+++ out/pr/tempo/values-k3d.yaml/sx-tempo/charts/tempo/templates/statefulset.yaml 2025-01-24 20:45:48.023545597 +0000
@@ -85,35 +85,15 @@
- mountPath: /conf
name: tempo-conf
- mountPath: /tmp
name: tmp
- - args:
- - --query.base-path=/
- - --grpc-storage-plugin.configuration-file=/conf/tempo-query.yaml
- image: grafana/tempo-query:2.7.0
- imagePullPolicy: IfNotPresent
- name: tempo-query
- ports:
- - containerPort: 16686
- name: jaeger-ui
- - containerPort: 16687
- name: jaeger-metrics
- env:
- resources:
- {}
- volumeMounts:
- - mountPath: /conf
- name: tempo-query-conf
securityContext:
fsGroup: 10001
runAsGroup: 10001
runAsNonRoot: true
runAsUser: 10001
volumes:
- configMap:
- name: tempo-query
- name: tempo-query-conf
- - configMap:
name: tempo
name: tempo-conf
- name: tmp
emptyDir: {} |
Changes Default Values |
Changes Default Values |
Changes Rendered ChartOnly in out/target/tempo/values-k3d.yaml/sx-tempo/charts/tempo/templates: configmap-tempo-query.yaml
diff -U 4 -r out/target/tempo/values-k3d.yaml/sx-tempo/charts/tempo/templates/service.yaml out/pr/tempo/values-k3d.yaml/sx-tempo/charts/tempo/templates/service.yaml
--- out/target/tempo/values-k3d.yaml/sx-tempo/charts/tempo/templates/service.yaml 2025-01-24 20:55:05.725468094 +0000
+++ out/pr/tempo/values-k3d.yaml/sx-tempo/charts/tempo/templates/service.yaml 2025-01-24 20:54:35.662562229 +0000
@@ -25,15 +25,8 @@
- name: tempo-prom-metrics
port: 3100
protocol: TCP
targetPort: 3100
- - name: jaeger-metrics
- port: 16687
- protocol: TCP
- targetPort: 16687
- - name: tempo-query-jaeger-ui
- port: 16686
- targetPort: 16686
- name: tempo-jaeger-thrift-http
port: 14268
protocol: TCP
targetPort: 14268
diff -U 4 -r out/target/tempo/values-k3d.yaml/sx-tempo/charts/tempo/templates/statefulset.yaml out/pr/tempo/values-k3d.yaml/sx-tempo/charts/tempo/templates/statefulset.yaml
--- out/target/tempo/values-k3d.yaml/sx-tempo/charts/tempo/templates/statefulset.yaml 2025-01-24 20:55:05.725468094 +0000
+++ out/pr/tempo/values-k3d.yaml/sx-tempo/charts/tempo/templates/statefulset.yaml 2025-01-24 20:54:35.663562225 +0000
@@ -85,35 +85,15 @@
- mountPath: /conf
name: tempo-conf
- mountPath: /tmp
name: tmp
- - args:
- - --query.base-path=/
- - --grpc-storage-plugin.configuration-file=/conf/tempo-query.yaml
- image: grafana/tempo-query:2.7.0
- imagePullPolicy: IfNotPresent
- name: tempo-query
- ports:
- - containerPort: 16686
- name: jaeger-ui
- - containerPort: 16687
- name: jaeger-metrics
- env:
- resources:
- {}
- volumeMounts:
- - mountPath: /conf
- name: tempo-query-conf
securityContext:
fsGroup: 10001
runAsGroup: 10001
runAsNonRoot: true
runAsUser: 10001
volumes:
- configMap:
- name: tempo-query
- name: tempo-query-conf
- - configMap:
name: tempo
name: tempo-conf
- name: tmp
emptyDir: {} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.