Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CNN class for MNIST handling and import it to main.py #34

Closed
wants to merge 3 commits into from

Conversation

sweep-nightly[bot]
Copy link

@sweep-nightly sweep-nightly bot commented Oct 13, 2023

Description

This PR adds a new CNN class for handling the MNIST dataset and imports it into the main.py file. The existing implementation in main.py uses a simple feed-forward neural network, and this PR replaces it with the new CNN class.

Summary of Changes

  • Created a new file src/cnn.py to define the CNN class.
  • Implemented the CNN class using PyTorch, with appropriate layers for handling 28x28 grayscale images.
  • Updated the import statement in src/main.py to import the CNN class from cnn.py.
  • Replaced the instantiation of the existing Net class with the new CNN class in the "Define the PyTorch Model" section of src/main.py.
  • Updated the training loop in src/main.py to accommodate the changes in the network architecture.
  • Added docstrings and comments to the CNN class and its methods, following the project's conventions.

Please review the changes and merge this PR if it meets the requirements.

Fixes #9.


🎉 Latest improvements to Sweep:

  • Sweep can now passively improve your repository! Check out Rules to learn more.

💡 To get Sweep to edit this pull request, you can:

  • Comment below, and Sweep can edit the entire PR
  • Comment on a file, Sweep will only modify the commented file
  • Edit the original issue to get Sweep to recreate the PR from scratch

@sweep-nightly
Copy link
Author

sweep-nightly bot commented Oct 13, 2023

Rollback Files For Sweep

  • Rollback changes to src/cnn.py
  • Rollback changes to src/main.py
  • Rollback changes to src/main.py
  • Rollback changes to src/main.py
  • Rollback changes to src/main.py

@sweep-nightly
Copy link
Author

sweep-nightly bot commented Oct 13, 2023

Apply Sweep Rules to your PR?

  • Apply: All docstrings and comments should be up to date.
  • Apply: Code should be properly formatted and indented.
  • Apply: Variable and function names should be descriptive and follow a consistent naming convention.
  • Apply: Imports should be organized and grouped together.
  • Apply: There should be no unused imports or variables.
  • Apply: Code should be properly commented and include docstrings for functions and classes.

@wwzeng1
Copy link
Contributor

wwzeng1 commented Oct 13, 2023

src/api.py:5:0: E0611: No name 'Net' in module 'main'

@sweep-nightly
Copy link
Author

sweep-nightly bot commented Oct 13, 2023

🚀 Wrote Changes

Done.

@wwzeng1 wwzeng1 closed this Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sweep: add a new cnn class that defines AND trains the cnn to handle mnist in cnn.py and import it to main.py
1 participant