Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two workarounds for autodiff specific optimizations with OSSA #78849

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

eeckstein
Copy link
Contributor

  • AutodiffClosureSpecialization
  • SILCombine of differential_function

Disable these optimizations for OSSA until the underlying problems are fixed.
#78847
#78848

Part of rdar://140229560

Disable the closure specializer optimization for closures in OSSA until the underlying problem is fixed.
swiftlang#78847

Part of rdar://140229560
Disable this peephole optimization until the underlying problem is fixed.
swiftlang#78848

Part of rdar://140229560
@eeckstein eeckstein requested review from jkshtj, meg-gupta and asl January 23, 2025 15:13
@eeckstein
Copy link
Contributor Author

@swift-ci smoke test

@eeckstein
Copy link
Contributor Author

@swift-ci smoke test

@eeckstein
Copy link
Contributor Author

@swift-ci smoke test macos

Copy link
Contributor

@asl asl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll take care of #78848

@eeckstein
Copy link
Contributor Author

@swift-ci clean smoke test macos

@eeckstein
Copy link
Contributor Author

@swift-ci test macos

@eeckstein eeckstein merged commit 694ee2d into swiftlang:main Jan 24, 2025
4 checks passed
@eeckstein eeckstein deleted the autodiff-workarounds branch January 24, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants