Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): removed documentaion and occurences of text-* utility classes #4399

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

schaertim
Copy link
Contributor

@schaertim schaertim commented Jan 8, 2025

No description provided.

@schaertim schaertim linked an issue Jan 8, 2025 that may be closed by this pull request
Copy link

changeset-bot bot commented Jan 8, 2025

🦋 Changeset detected

Latest commit: 6263304

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@swisspost/design-system-documentation Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

sonarqubecloud bot commented Jan 8, 2025

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Jan 8, 2025

Related Previews

@schaertim schaertim changed the title chore(docs): removed documentaion and occurences of text-\* utility c… chore(docs): removed documentaion and occurences of text-* utility classes Jan 9, 2025
@schaertim schaertim marked this pull request as ready for review January 9, 2025 07:58
@schaertim schaertim requested review from a team as code owners January 9, 2025 07:58
@schaertim schaertim requested a review from leagrdv January 9, 2025 07:58
@@ -95,11 +95,9 @@ export const Default: Story = {
};

const colorVariants = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the icon.docs.mdx file, just above the color example, the text should be edited as it mentions the the text color utilities.

### Color

Colorize text with `.text-*` utility classes.
To colorize links, use the `.link-*` classes instead as they also provide styling for the `:hover` and `:focus` states.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The `.link-* classes documentation has been deleted, could you please check that there is no more usage of those classes elsewhere in the docs?

Comment on lines -110 to -114
### Reset Color

Reset a text color with `.text-reset`, so that an element inherits the color from its parent.

<Canvas of={TextStories.TextColorReset} sourceState="shown" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class might still be useful and is not directly related to the .text-* color classes.

'@swisspost/design-system-documentation': minor
---

Removed documentaion and occurences of text-\* utility classes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Removed documentaion and occurences of text-\* utility classes.
Removed occurences of `.text-*` and `.link-*` color utility classes and its documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text color classes usage in documentation
3 participants