Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for pushing SIF images directly to OCI registry #151

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

EmmEff
Copy link
Contributor

@EmmEff EmmEff commented Nov 17, 2022

As above... follows work for OCI direct downloads in #150

#150 must be merged first

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2022

Codecov Report

Merging #151 (56cb352) into main (915e8a8) will decrease coverage by 6.19%.
The diff coverage is 15.98%.

❗ Current head 56cb352 differs from pull request most recent head 3f146c2. Consider uploading reports for the commit 3f146c2 to get more accurate results

@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
- Coverage   41.25%   35.06%   -6.20%     
==========================================
  Files          13       13              
  Lines        1738     2042     +304     
==========================================
- Hits          717      716       -1     
- Misses        938     1243     +305     
  Partials       83       83              
Impacted Files Coverage Δ
client/push.go 10.87% <0.00%> (-0.19%) ⬇️
client/oci.go 5.38% <5.38%> (-4.56%) ⬇️
client/client.go 94.54% <25.00%> (ø)
client/pull.go 53.94% <67.44%> (ø)
client/downloader.go 75.00% <75.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@EmmEff EmmEff force-pushed the oci-direct-upload branch 3 times, most recently from 51d9b36 to faa1b6e Compare December 9, 2022 18:57
@EmmEff EmmEff marked this pull request as ready for review December 9, 2022 19:13
Copy link
Member

@tri-adam tri-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion, otherwise LGTM. Thank you.

client/oci.go Outdated Show resolved Hide resolved
@EmmEff EmmEff force-pushed the oci-direct-upload branch from faa1b6e to 3f146c2 Compare December 9, 2022 19:41
@EmmEff EmmEff merged commit 2dba38c into sylabs:main Dec 9, 2022
@EmmEff EmmEff deleted the oci-direct-upload branch December 9, 2022 19:42
@DrDaveD
Copy link

DrDaveD commented Dec 19, 2022

Does this and #151 have an impact on the library API standard? Does the standard need an extension?

@dtrudg
Copy link
Member

dtrudg commented Dec 19, 2022

With respect to the API standard, please see singularityhub/library-api#5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants