Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare RC #376

Merged
merged 1 commit into from
Jul 28, 2017
Merged

Prepare RC #376

merged 1 commit into from
Jul 28, 2017

Conversation

ElectricMaxxx
Copy link
Member

Merge and release when green.

@ElectricMaxxx ElectricMaxxx requested a review from dbu July 27, 2017 06:22
@dbu
Copy link
Member

dbu commented Jul 27, 2017

looks good. lets see that we can wrap up the sonata integration...

@ElectricMaxxx ElectricMaxxx changed the title Prepare 2.0 Prepare RC Jul 27, 2017
@ElectricMaxxx
Copy link
Member Author

Looks cool now, i squashed and will release RC then.

@ElectricMaxxx ElectricMaxxx merged commit 26992b2 into master Jul 28, 2017
@ElectricMaxxx ElectricMaxxx deleted the prepare_2.0 branch July 28, 2017 11:15
dbu
dbu reviewed Jul 28, 2017
View reviewed changes
app/config/config.yml
document_tree:
Doctrine\ODM\PHPCR\Document\Generic:
valid_children:
- all
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we get completely rid of the feature to define what can be where in the tree? or did it just move elsewhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. The tree itself, as code construct, currently has got no restrictions anymore. But i think we should introduce a kind of an enhancer which add the doctrine-phpcr information into the response and force the tree-browser to use that one. And yes i think we need those restrictions at least when restrict the targets on which we are able to move. But that is no feature of fancytree as far as i know – we have to implement that on our own js code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ElectricMaxxx @dbu