conditionally WebSerBundle, new sonata integration release #378
Conversation
|
Now it works fine and fluffy. |
|
@dbu you know which environment is deployed to this plattform.sh ? I got a completely different behavior then local. All move routes got a Btw: i think we/i need a next improvement on the tree-browser: movements within one collection (reorder only) should not do a move call – reorder only: symfony-cmf/tree-browser-bundle#157 No clue if that is a nice to have or must have for releasing sonata stuff. |
app/AppKernel.php
Outdated
| @@ -70,6 +70,10 @@ public function registerBundles() | |||
| new AppBundle\AppBundle(), | |||
| ]; | |||
|
|
|||
| // Symfony 3.3 moved server:* commands to another bundle | |||
There was a problem hiding this comment.
the sandbox need not be generic. lets require that web server bundle and simply instantiate it
There was a problem hiding this comment.
That won't work i think. For Symfony < 3.3 the functions (server:run, ...) works on demand. From Symfony 3.3 those stuff comes from WebServerBundle, which does not exist befor. So what won't work, or i don't know how, is to require conditional dependencies.
This way it works as Symfony requires it by its own.
There was a problem hiding this comment.
imho we should simply update
Line 21 in 04b0e98
"symfony/symfony": "^3.3". the sandbox is not about supporting as many versions as possible.
There was a problem hiding this comment.
ahh ok, this travis does not iterate over many versions.
|
great! thanks a lot! |
No description provided.