Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

output when there is output #394

Merged
merged 2 commits into from
Nov 8, 2017
Merged

output when there is output #394

merged 2 commits into from
Nov 8, 2017

Conversation

ElectricMaxxx
Copy link
Member

No description provided.

dbu
dbu reviewed Nov 8, 2017
View reviewed changes
Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea. just a nitpick

web/reload-fixtures.php Outdated
echo "Output:\n";
foreach ($output as $line) {
echo $line."\n";
if ($shouldHaveOutput) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets invert this: if !$shouldHaveOutput return

@ElectricMaxxx ElectricMaxxx merged commit 2a8a6ab into master Nov 8, 2017
@ElectricMaxxx ElectricMaxxx deleted the fix_reload branch November 8, 2017 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ElectricMaxxx @dbu