Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust some more paths from app to var #396

Merged
merged 1 commit into from
Nov 27, 2017
Merged

adjust some more paths from app to var #396

merged 1 commit into from
Nov 27, 2017

Conversation

lsmith77
Copy link
Member

No description provided.

@ElectricMaxxx
Copy link
Member

Thanks a lot. The build error looks wired.

@lsmith77
Copy link
Member Author

yeah :-/

@lsmith77
Copy link
Member Author

BTW .. we might want to also do some simple log rotation to prevent things from filling up the disk .. maybe move the logs daily to a file named by the day of the week or something

@ElectricMaxxx
Copy link
Member

@lsmith77 but the the file would lay on the same disk and fill it up too? isn't it?
Btw: you got some log/monitor access to our platform.sh instances?

@dbu
Copy link
Member

dbu commented Nov 27, 2017

if the log file name is only the day of week without date, it should work. but could we just not log to files at all on platform.sh? i don't think anybody ever looks at those files.

i restarted the build, this seems repeatable. it seems to use some "build cache", maybe a one-time fluke got cached in there?

@dbu
Copy link
Member

dbu commented Nov 27, 2017

i restarted the build on master, and it now fails with the same error. thus its not related to this PR and i will merge it as the fixes look correct.

@dbu dbu merged commit ec20a57 into master Nov 27, 2017
@dbu dbu deleted the fix-paths branch November 27, 2017 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants