Make build run again in fix_master branch #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yea nice, now we do see the issue :-) cool. |
|
thanks @SenseException ! can you try to fix the styleci issues please? looks like sonata cache expects a method getDocument to exist on the PreUpdateEventArgs of phpcr-odm. i created sonata-project/cache#103 - i think that sonata cache invalidator never worked. on our end, i think we should not be running any active sonata cache invalidation. is it coming from sonata admin? |
SenseException
force-pushed
the
fix_master
branch
from
6fed9ed to
a6e6a34
Compare
Done |
|
I will merge this one into master at all, as it makes the test better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about a suggestion for the described problem in #397, where a travis-ci builds just stop. This PR is not about making the tests go green, but to make the build run till the end again.