-
Notifications
You must be signed in to change notification settings - Fork 15
[WIP] move, rename delete resource of editable repository #31
[WIP] move, rename delete resource of editable repository #31
Conversation
@dantleech got an other issue with the factories of the
For some reasons |
@@ -1,6 +1,6 @@ | |||
# Symfony CMF Resource REST API Bundle | |||
|
|||
[![Build Status](https://secure.travis-ci.org/symfony-cmf/ResourceRestBundle.png?branch=master)](http://travis-ci.org/symfony-cmf/ResourceRestBundle) | |||
[![Build Status](https://travis-ci.org/symfony-cmf/resource-rest-bundle.svg?branch=master)](https://travis-ci.org/symfony-cmf/resource-rest-bundle) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the build icon change all other bundles still have.
5211e6b
to
324a451
Compare
324a451
to
e6de622
Compare
} | ||
|
||
/** | ||
* There are two different changes that can currently be done on a cmf resource: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the styleci complains because the first line of a comment is the short description.
we should say something like "Change an existing resource." and then add a new line.
For some reason, using this PR in the CMF sandbox always results in the following error:
Which is quite strange, as it involves a lot of things that shouldn't really need to be serialized. Without this PR, but with the resource and resourcebundle move/remove PRs, things work without errors. |
@wouterj yea i think we need some exclusions on the documents and the resource itself, i think got the same issue on my on try on the sandbox :-) |
But the strange thing is that things work perfectly without this PR. Unless I'm wrong, you don't change anything about the |
@wouterj yes, you are right. That's really strange. |
Hmm, I think I have a clue about why this issue is happening and how to solve it. Let's see... |
I would pass an other problem: started testing patch, created request (test) and the body is empty inside the controller. |
You have to revert all Because this is now wrong, the serializer handlers aren't executed and the JMS serializer simply serializes everything in the Document, including the doctrine manager and full container. |
uhh you are right, did that on my bundle PR :-) |
_controller: cmf_resource_rest.controller.resource:patchResourceAction | ||
_format: json | ||
|
||
_get_cmf_resource: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to put the vendor in front: _cmf_get_resource
Closing in favor of #36 |
This i the WIP PR to test an try the EditableRepository interface of both repositories in the component.