Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

Use puli-light included int the component #39

Merged
merged 10 commits into from
Jan 26, 2017
Merged

Use puli-light included int the component #39

merged 10 commits into from
Jan 26, 2017

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Dec 27, 2016

@wouterj wouterj added this to the 1.0 milestone Dec 27, 2016
@dbu
Copy link
Member

dbu commented Jan 26, 2017

now its only lowest version that has an issue. i guess its installing a too old resource-bundle:

Fatal error: Call to undefined method Symfony\Cmf\Bundle\ResourceBundle\Tests\Unit\DependencyInjection\CmfResourceRestExtensionTest::hasExpectationOnOutput()

@wouterj
Copy link
Member Author

wouterj commented Jan 26, 2017

@dbu no, there is a problem with the included PHPunit. The WebApiExtension requires PHPunit, which installs PHPunit in the vendor/ and overrides the PHPunit version installed with simple-phpunit. This means we're using PHPunit 4.0 in the lowest dep builds, which doesn't come with Prophecy support.

Currently working on improving our Behat tests, so we can remove WebApiExtension.

@wouterj wouterj force-pushed the include-puli branch 2 times, most recently from 2fabe74 to f55843e Compare January 26, 2017 11:46
@wouterj wouterj merged commit c65c7ad into master Jan 26, 2017
@wouterj wouterj deleted the include-puli branch January 26, 2017 13:44
@wouterj
Copy link
Member Author

wouterj commented Jan 26, 2017

I didn't even know it was possible, but the build is green now :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants