Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

Move admin enhancers out of here. #34

Closed
dantleech opened this issue Jul 28, 2016 · 5 comments · Fixed by #42, symfony-cmf/resource-bundle#41 or symfony-cmf/sonata-phpcr-admin-integration-bundle#76
Closed

Move admin enhancers out of here. #34

dantleech opened this issue Jul 28, 2016 · 5 comments · Fixed by #42, symfony-cmf/resource-bundle#41 or symfony-cmf/sonata-phpcr-admin-integration-bundle#76
Assignees
@ElectricMaxxx
Milestone
1.0

Comments

@dantleech
Copy link
Member

dantleech commented Jul 28, 2016 •
edited by ElectricMaxxx
Loading

The Sonata Enhancer can live in the as-yet-not-existing CmfSonataAdminBundle.

The Sylius Enhancer should live in an equivilent place.

These are integration enhancers, and should be part of an integration package which has all of the relevant dependencies.
@dantleech dantleech changed the title Move admin enhcners out of here. Move admin enhancers out of here. Jul 28, 2016
@wouterj wouterj modified the milestone: 1.0 Jan 22, 2017
@ElectricMaxxx
Copy link
Member

As the sonata-admin-integration-bundle exists now it is now open for the enhancer.

@wouterj wouterj closed this as completed Jan 26, 2017
@wouterj wouterj reopened this Jan 26, 2017
@ElectricMaxxx
Copy link
Member

So i will take sonata first.

@ElectricMaxxx ElectricMaxxx self-assigned this Jan 27, 2017
This was referenced Jan 27, 2017
Merged
Merged
Merged
@ElectricMaxxx
Copy link
Member

@dantleech @wouterj what to do with the sylius, remove first?
where to add?

@wouterj
Copy link
Member

wouterj commented Jan 27, 2017

Keep in here I would say

@ElectricMaxxx
Copy link
Member

but i need to revert the commit then :-)

@wouterj wouterj removed the wip/poc label Jan 27, 2017
@wouterj wouterj reopened this Jan 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ElectricMaxxx ElectricMaxxx

Labels
None yet
Projects
None yet
Milestone
1.0
3 participants
@dantleech @wouterj @ElectricMaxxx