moves the sonata admin description enhancer from resource component #76
Conversation
|
Now the php version changes are hitting me. |
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Enhancer; |
There was a problem hiding this comment.
I would rather put this in Description
There was a problem hiding this comment.
i was unclear about the naming.
| @@ -12,7 +12,7 @@ | |||
| public="false"> | |||
| <argument type="service" id="sonata.admin.pool" /> | |||
| <argument type="service" id="router" /> | |||
| <tag name="cmf_resource.description.enhancer" alias="sonata_admin" /> | |||
| <tag name="cmf_resource.description.enhancer" alias="sonata_phpcr_admin_integration" /> | |||
There was a problem hiding this comment.
I would still call this sonata_admin
There was a problem hiding this comment.
As the master of resource-bundle still has that alias i got an collision. And when having a orm version with an description enhancer, we will have a collision too.
There was a problem hiding this comment.
so at least i would keep the phpcr somewhere.
| @@ -149,12 +149,16 @@ public function testEnhancerExists() | |||
| [ | |||
| 'SonataDoctrinePHPCRAdminBundle' => true, | |||
| 'SonataAdminBundle' => true, | |||
| 'JMSSerializerBundle' => true, | |||
There was a problem hiding this comment.
but in AppKernel ..
| public="false"> | ||
| <argument type="service" id="sonata.admin.pool" /> | ||
| <argument type="service" id="router" /> | ||
| <tag name="cmf_resource.description.enhancer" alias="sonata_phpcr_admin_integration" /> |
There was a problem hiding this comment.
Let's do sonata_phpcr_admin then.
| * | ||
| * @internal | ||
| */ | ||
| class ResourceEnhancer implements DescriptionEnhancerInterface |
There was a problem hiding this comment.
All description enhancers describe resources. I would call this SonataEnhancer or the like, this specific enhancer implementation is about adding things that Sonata knows about our document (links, names, etc.)
fix tests move classes changes due to hints
ElectricMaxxx
force-pushed
the
resource_enhancer
branch
from
684f4cc to
8efe19c
Compare
|
Changed the requested stuff, squashed it. Ready to merge. |
fix symfony-cmf/resource#34
move sonata admin description enhancer.