Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

[WIP] Fixed reorder to 0 #30

Merged
merged 1 commit into from
Jul 4, 2016
Merged

[WIP] Fixed reorder to 0 #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Repository/PhpcrOdmRepository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,9 @@ public function reorderNode($sourcePath, $position)
$nodeNames = $parent->getNodeNames();
$parentDocument = $this->getManager()->find(null, $parent->getPath());

if (isset($nodeNames[$position + 1])) {
if ($position == 0) {
$this->getManager()->reorder($parentDocument, $node->getName(), $nodeNames[$position], true);
} elseif (isset($nodeNames[$position + 1])) {
$this->getManager()->reorder($parentDocument, $node->getName(), $nodeNames[$position + 1], true);
} else {
$lastName = end($nodeNames);
Expand Down
4 changes: 3 additions & 1 deletion Repository/PhpcrRepository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,9 @@ public function reorderNode($sourcePath, $position)
$parent = $node->getParent();
$nodeNames = $parent->getNodeNames();

if (isset($nodeNames[$position + 1])) {
if ($position == 0) {
$parent->orderBefore($node->getName(), $nodeNames[$position]);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other edge cases here? $nodeNames[0] should always be set.

} elseif (isset($nodeNames[$position + 1])) {
$parent->orderBefore($node->getName(), $nodeNames[$position + 1]);
} else {
$lastName = $nodeNames[count($nodeNames) - 1];
Expand Down