Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

Github Templates - DevKit updates #52

Merged
merged 2 commits into from
May 16, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/Bug_report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
---
name: Bug Report
about: Report errors and problems

---

<!--
The Symfony Code of Conduct applies to all the activity on this repository.
See https://symfony.com/doc/current/contributing/code_of_conduct/index.html
-->

**Description**
<!-- A clear and concise description of the problem. -->

**How to reproduce**
<!-- Code and/or config needed to reproduce the problem. If it's a complex bug,
create a "bug reproducer" as explained in:
https://symfony.com/doc/current/contributing/code/reproducer.html -->

**Possible Solution**
<!--- Optional: only if you have suggestions on a fix/reason for the bug -->

**Additional context**
<!-- Optional: any other context about the problem: log messages, screenshots, etc. -->
10 changes: 10 additions & 0 deletions .github/Documentation_issue.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
name: Documentation Issue
about: Anything related to Symfony CMF Documentation

---

Symfony CMF Documentation has its own dedicated repository. Please open your
documentation-related issue at https://github.com/symfony-cmf/symfony-cmf-docs/issues

Thanks!
12 changes: 12 additions & 0 deletions .github/Feature_request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
name: Feature Request
about: RFC and ideas for new features and improvements

---

**Description**
<!-- A clear and concise description of the new feature. -->

**Example**
<!-- A simple example of the new feature in action (include PHP code, YAML config, etc.)
If the new feature changes an existing feature, include a simple before/after comparison. -->
9 changes: 9 additions & 0 deletions .github/Security_issue.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
name: Security Issue
about: Report security-related errors

---

If you have found a security issue in Symfony, please send the details to
[David](mailto:[email protected]) or [Maximilian](mailto:[email protected]) and don't disclose it publicly until we can provide a
fix for it.
15 changes: 15 additions & 0 deletions .github/Support_question.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
name: Support Question
about: Questions about using Symfony CMF and its components

---

**Description**
<!-- A clear and concise description of the problem. -->

**How to reproduce (optional)**
<!-- Optional: Only if you have something to reproduce. Code and/or config needed to reproduce the problem. -->

**Possible Solution**
<!-- Optional: only if you have suggestions to solve it -->

10 changes: 10 additions & 0 deletions src/Description/Descriptor.php
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,15 @@ final class Descriptor
* Values should be either a valid URI.
*/
const LINK_EDIT_HTML = 'link.edit.html';

const LINK_CREATE_HTML = 'link.create.html';

const LINK_UPDATE_HTML = 'link.update.html';

const LINK_REMOVE_HTML = 'link.remove.html';

const LINK_SHOW_HTML = 'link.show.html';

const LINK_LIST_HTML = 'link.list.html';

/**
Expand All @@ -58,10 +63,15 @@ final class Descriptor
* Values should be either a valid URI.
*/
const LINK_EDIT_REST = 'link.edit.rest';

const LINK_CREATE_REST = 'link.create.rest';

const LINK_UPDATE_REST = 'link.update.rest';

const LINK_REMOVE_REST = 'link.remove.rest';

const LINK_SHOW_REST = 'link.show.rest';

const LINK_LIST_REST = 'link.show.rest';

/**
Expand Down
3 changes: 3 additions & 0 deletions tests/Unit/Description/DescriptionFactoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,11 @@
class DescriptionFactoryTest extends \PHPUnit_Framework_TestCase
{
private $factory;

private $enhancer1;

private $enhancer2;

private $resource;

public function setUp()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,15 @@
class PhpcrOdmEnhancerTest extends \PHPUnit_Framework_TestCAse
{
private $metadataFactory;

private $enhancer;

private $cmfResource;

private $puliResource;

private $odmMetadata;

private $description;

public function setUp()
Expand Down
1 change: 1 addition & 0 deletions tests/Unit/Repository/AbstractPhpcrRepositoryTestCase.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
abstract class AbstractPhpcrRepositoryTestCase extends \PHPUnit_Framework_TestCase
{
protected $finder;

protected $session;

public function setUp()
Expand Down
8 changes: 8 additions & 0 deletions tests/Unit/Repository/PhpcrOdmRepositoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,21 @@
class PhpcrOdmRepositoryTest extends AbstractPhpcrRepositoryTestCase
{
private $documentManager;

private $managerRegistry;

private $childrenCollection;

private $uow;

private $document;

private $child1;

private $child2;

private $node1;

private $node2;

public function setUp()
Expand Down
2 changes: 2 additions & 0 deletions tests/Unit/Repository/PhpcrRepositoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@
class PhpcrRepositoryTest extends AbstractPhpcrRepositoryTestCase
{
protected $node;

protected $node1;

protected $node2;

public function setUp()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
class PhpcrMetadataTest extends \PHPUnit_Framework_TestCase
{
private $node;

private $property;

public function setUp()
Expand Down