[ci] windows tests on GitHub actions #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrushlow
added
Status: Needs Work
jrushlow
force-pushed
the
ci/windows
branch
2 times, most recently
from
d697f28 to
9fb8bdb
Compare
jrushlow
commented
Jan 26, 2024
jrushlow
force-pushed
the
ci/windows
branch
4 times, most recently
from
f915a14 to
ee61d6a
Compare
jrushlow
changed the title
jrushlow
added
Status: Needs Review
jrushlow
commented
Feb 3, 2024
| use PHPUnit\Framework\TestCase; | ||
| use Symfony\Bundle\MakerBundle\Test\MakerTestEnvironment; | ||
|
|
||
| class RegexTest extends TestCase |
There was a problem hiding this comment.
Calling this MakeTestEnvironmentTest was not compatible with PHPUnit --filter (test wouldn't run) and I'm not sure it was running w/ just simple-phpunit && no flags either...
jrushlow
added
Status: Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests that use
symfony/pantherare skipped on windows. The windows runner does not chrome/firefox/etc pre-installed.fixes regex that gets a list of files create or updated by MakerBundle (used to test those files were actually created). the file path in the output differs on linux, github actions linux images, macos, & windows. The new regex pattern handles all of those cases. This regex is only used in Maker tests
adds a test for that regex to protect from hidden test failures in the future.