update the FROM_STRING_PATTERN inside Address.php #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! We love contributions. However, you should instead open a pull request on the main repository: https://github.com/symfony/symfony This repository is what we call a "subtree split": a read-only subset of that main repository. We're looking forward to your PR there! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
FROM_STRING_PATTERNinside Address.php.As it is right now strings with the character inside the display name "<" will not parse correctly. For example the string "Andre Hoong <3 [email protected]" will have the following matches returned using the current pattern:
displayName => Andre Hoong
addrSpec => 3 <[email protected]
The new string pattern '
(?.)?<(?.)>[^>]*' allows the displayName to include the "<" character and correctly parses the addrSpec. It does this by taking the last occurence of the "<" to singal the start of the addrSpec