Don't store broken roles in the cache.json #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #963 +/- ##
==========================================
+ Coverage 84.14% 84.36% +0.22%
==========================================
Files 42 42
Lines 3058 3057 -1
==========================================
+ Hits 2573 2579 +6
+ Misses 392 384 -8
- Partials 93 94 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
If you had a role defined in config.yaml we would present the role in the `list` command, even if it didn't exist. Now we generate a warning and filter them out. Fixes: #962
synfinatic
force-pushed
the
update-delete-roles
branch
from
7f33f94 to
4c770f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you had a role defined in config.yaml we would present the role in the
listcommand, even if it didn't exist. Now we generate a warning and filter them out.Fixes: #962