Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make spike count plot optional #240

Merged

Conversation

bauerfe
Copy link
Contributor

@bauerfe bauerfe commented Jun 14, 2024

Checklist before requesting a review

  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)
  • I have performed a self-review of my code
  • Will this be part of a product update? If yes, please write one line about this on the CHANGELOG.md
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Improves DynapcnnVisualizer class by making spike count plot optional. Addresses Dynapcnn Visualizer: Enable excluding spike count plot #238 .

  • What is the current behavior? (You can also link to an open issue here)
    GUI of DynapcnnVisualizer always shows spike count plot.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No.

@bauerfe bauerfe requested a review from ssinhaleite June 14, 2024 10:45
@bauerfe bauerfe self-assigned this Jun 14, 2024
@bauerfe bauerfe linked an issue Jun 14, 2024 that may be closed by this pull request
@ssinhaleite
Copy link
Member

Hi @bauerfe ,

I've reviewed your changes, and they look good.
I am merging it, but just FYI, I am adding two new issues that I caught while reviewing this code (but that are not directly related to this feature).

Thanks!

@ssinhaleite ssinhaleite merged commit 9b5cf77 into develop Jun 14, 2024
12 checks passed
@ssinhaleite ssinhaleite deleted the 238-dynapcnn-visualizer-enable-excluding-spike-count-plot branch June 14, 2024 13:09
Copy link
Member

@ssinhaleite ssinhaleite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynapcnn Visualizer: Enable excluding spike count plot
2 participants