Improved isSupported() implementation

syranide · Oct 6, 2015 · 48b5ad1 · 48b5ad1
1 parent f01e43c
commit 48b5ad1
Show file tree

Hide file tree

Showing 8 changed files with 21 additions and 21 deletions.
diff --git a/README.md b/README.md
@@ -13,13 +13,13 @@ if (SWFPlayerVersion.isSupported('10.0')) {
 
 ```
 get()
-  returns {?string} 'X.Y.Z' or null.
+  returns {?string} '#.#.#' or null.
 
   Get available SWF Player version. Result is cached.
 ```
 ```
 isSupported(requiredString)
-  requiredString {string} 'X.Y.Z', 'X.Y' or 'X'.
+  requiredString {string} '#.#.#', '#.#', '#' or ''.
   returns {boolean} true if supported.
 
   Determine if available SWF Player meets version requirement.

diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "swf-player-version",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "license": "MIT",
   "description": "Shockwave Flash Player version utility",
   "authors": ["Andreas Svensson <[email protected]>"],

diff --git a/npm-swf-player-version/README.md b/npm-swf-player-version/README.md
@@ -13,13 +13,13 @@ if (SWFPlayerVersion.isSupported('10.0')) {
 
 ```
 get()
-  returns {?string} 'X.Y.Z' or null.
+  returns {?string} '#.#.#' or null.
 
   Get available SWF Player version. Result is cached.
 ```
 ```
 isSupported(requiredString)
-  requiredString {string} 'X.Y.Z', 'X.Y' or 'X'.
+  requiredString {string} '#.#.#', '#.#', '#' or ''.
   returns {boolean} true if supported.
 
   Determine if available SWF Player meets version requirement.

diff --git a/npm-swf-player-version/package.json b/npm-swf-player-version/package.json
@@ -1,6 +1,6 @@
 {
   "name": "swf-player-version",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "license": "MIT",
   "description": "Shockwave Flash Player version utility",
   "author": "Andreas Svensson <[email protected]>",

diff --git a/npm-swf-player-version/swf-player-version.js b/npm-swf-player-version/swf-player-version.js
@@ -1,4 +1,4 @@
-/*! swf-player-version v1.1.0 | @syranide | MIT license */
+/*! swf-player-version v1.1.1 | @syranide | MIT license */
 
 'use strict';
 
@@ -48,7 +48,7 @@ function detectAvailableVersion() {
 /**
  * Get available SWF Player version. Result is cached.
  *
- * @return {?string} 'X.Y.Z' or null.
+ * @return {?string} '#.#.#' or null.
  */
 function getVersion() {
   if (detectedVersion === undefined) {
@@ -61,7 +61,7 @@ function getVersion() {
 /**
  * Determine if available SWF Player meets version requirement.
  *
- * @param {string} requiredString 'X.Y.Z', 'X.Y' or 'X'.
+ * @param {string} requiredString '#.#.#', '#.#', '#' or ''.
  * @return {boolean} true if supported.
  */
 function isVersionSupported(requiredString) {
@@ -74,9 +74,9 @@ function isVersionSupported(requiredString) {
   var availableFields = availableString.split('.');
   var requiredFields = requiredString.split('.');
 
-  for (var i = 0; i < 3; i++) {
-    var availableField = availableFields[i];
-    var requiredField = requiredFields[i] || '0';
+  for (var i = 0; i < requiredFields.length; i++) {
+    var availableField = availableFields[i] || '0';
+    var requiredField = requiredFields[i];
 
     if (availableField !== requiredField) {
       return +availableField > +requiredField;

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "swf-player-version",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "license": "MIT",
   "description": "Shockwave Flash Player version utility",
   "author": "Andreas Svensson <[email protected]>",

diff --git a/swf-player-version.js b/swf-player-version.js
@@ -1,4 +1,4 @@
-/*! swf-player-version v1.1.0 | @syranide | MIT license */
+/*! swf-player-version v1.1.1 | @syranide | MIT license */
 
 (function(root, factory) {
   if (typeof define === 'function' && define.amd) {
@@ -57,7 +57,7 @@
   /**
    * Get available SWF Player version. Result is cached.
    *
-   * @return {?string} 'X.Y.Z' or null.
+   * @return {?string} '#.#.#' or null.
    */
   function getVersion() {
     if (detectedVersion === undefined) {
@@ -70,7 +70,7 @@
   /**
    * Determine if available SWF Player meets version requirement.
    *
-   * @param {string} requiredString 'X.Y.Z', 'X.Y' or 'X'.
+   * @param {string} requiredString '#.#.#', '#.#', '#' or ''.
    * @return {boolean} true if supported.
    */
   function isVersionSupported(requiredString) {
@@ -83,9 +83,9 @@
     var availableFields = availableString.split('.');
     var requiredFields = requiredString.split('.');
 
-    for (var i = 0; i < 3; i++) {
-      var availableField = availableFields[i];
-      var requiredField = requiredFields[i] || '0';
+    for (var i = 0; i < requiredFields.length; i++) {
+      var availableField = availableFields[i] || '0';
+      var requiredField = requiredFields[i];
 
       if (availableField !== requiredField) {
         return +availableField > +requiredField;

diff --git a/swf-player-version.min.js b/swf-player-version.min.js