-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scale frequency to suppress RCU CPU stall warning #67
Open
Mes0903
wants to merge
2
commits into
sysprog21:master
Choose a base branch
from
Mes0903:scale-frequency
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+236
−17
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
#!/usr/bin/env bash | ||
|
||
# Create a directory to store logs (optional) | ||
mkdir -p logs | ||
|
||
for N in $(seq 1 32); do | ||
echo "=============================================" | ||
echo "Starting experiment with SMP=$N" | ||
echo "=============================================" | ||
|
||
# 1) Clean | ||
make clean | ||
|
||
# 2) Build and run checks with SMP=N, capturing emulator output | ||
# The 'tee' command copies output to the terminal AND a log file | ||
echo "Building and running 'make check SMP=$N'..." | ||
make check SMP=$N 2>&1 | tee "logs/emulator_SMP_${N}.log" | ||
|
||
# 3) After the emulator run, record gprof output | ||
# We assume 'gprof ./semu' uses data from 'gmon.out' | ||
echo "Running gprof for SMP=$N..." | ||
gprof ./semu > "logs/gprof_SMP_${N}.log" 2>&1 | ||
|
||
echo "Done with SMP=$N. Logs saved:" | ||
echo " - logs/emulator_SMP_${N}.log" | ||
echo " - logs/gprof_SMP_${N}.log" | ||
echo | ||
done | ||
|
||
echo "All experiments complete!" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest moving
boot_complete
variable intovm_t
for a more conceptually accurate design.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we move
boot_complete
intovm_t
, all existing functions for semu_timer_t would need an additionalvm_t
parameter. For example,semu_timer_get
would change to:This change would indirectly require the areas that call this function to also pass in a
vm_t
parameter. For instance, sincesemu_timer_get
is called withinaclint_mtimer_update_interrupts
, the API ofaclint_mtimer_update_interrupts
would also need to be updated to includevm_t
.As this pattern continues, the API changes would proliferate significantly. Perhaps we could introduce a static bool pointer pointing to
boot_complete
and assign its value duringsemu_timer_init
. This way, we would only need to modify the parameters ofsemu_timer_init
.