Mira r2 support #13
Open
Mira r2 support #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I updated this to also match "thelio-mira-r3" and it worked on my system. |
|
I can't personally vouch for all the other changes in this PR, so I made a simpler one that just adds support for thelio-mira-r2 and thelio-mira-r3: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most important change in this update is the addition of the
"thelio-mira-r2"product version identifier to the switch statement that selects a fan curve.The other significant change is bumping the toolchain version to
stableto keep this project in-line with the system76-power repository. The addition of the#[must_use]decorator toFanCurve::appendwas added for the same reason.The rest of the changes will hopefully make the comments and code more readable, but are entirely non-functional.