#208 v2 #209
Closed
#208 v2 #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabijaczleweli
force-pushed
the
version-updates
branch
from
d2c02ba to
a9b2db2
Compare
Version 2 is really old. We can update to 3 very easily. But it seems 4 will require some changes, so let's do that in a separate step. This is what https://github.com/clap-rs/clap/blob/v4.5.21/CHANGELOG.md#migrating recommends.
This changes the organization of the arguments and strictly speaking is an incompatible change. Before, the device argument could be specified before --reset-device or --setup-device, but now it must be after the option name. I think this is an acceptable change, because this isn't really a public interface and this is the natural way to specify this. This way the setup is simpler and easier to understand at a glance. I added #[rustfmt::skip] because the formatter insists on squishing some arg descriptions into a single line which doesn't look good and also indents the modifiers after '--setup-device' and 'dir' options differently for some reason. [#[rustfmt::skip] moved, attributes on expressions are experimental error] [<String>+.clone() -> <&str>+.to_string() removes a copy]
The generated output is not very readable. We can do better by providing a custom string. This makes the binary smaller too. [Drop indep]
nabijaczleweli
force-pushed
the
version-updates
branch
from
a9b2db2 to
a22ce97
Compare
|
Oh, I missed the updates here. I'll update the PR in a sec. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See bits with [] for changes to original.