fix(simple): timeout usage #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 31, 2024
t3hmrman
force-pushed
the
fix/simple/timeout-usage
branch
from
12935c3 to
890767c
Compare
The previous implementation of timeouts for dropping had a bug -- the timeout value was saved *after* calling `std::mem::take`, and was referring to the new `T::default()` instance's value of `timeout`, which is always `None`. This commit fixes the timeout usage by taking the timeout value before `std::mem::take`. Co-authored-by: Linken Quy Dinh <[email protected]>
t3hmrman
force-pushed
the
fix/simple/timeout-usage
branch
from
890767c to
d32688c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of timeouts for dropping had a bug -- the timeout value was saved after calling
std::mem::take, and was referring to the newT::default()instance's value oftimeout, which is alwaysNone.This commit fixes the timeout usage by taking the timeout value before
std::mem::take.