Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0.3] Available from PIP for Ubuntu 18.04 + Python 3.6 #96

Closed
wants to merge 1 commit into from

Conversation

hswong3i
Copy link

@hswong3i hswong3i commented Jun 24, 2022

From 7fc0602 the minimal Python requirement >= 3.7, but https://pypi.org/project/railroad-diagrams/2.0.3/ is still availble from PIP for Ubuntu 18.04 + Python 3.6:

root@748b3d29b97a:~# lsb_release -a
LSB Version:    core-9.20170808ubuntu1-noarch:security-9.20170808ubuntu1-noarch
Distributor ID: Ubuntu
Description:    Ubuntu 18.04.6 LTS
Release:    18.04
Codename:   bionic

root@748b3d29b97a:~# python3 --version
Python 3.6.9

root@748b3d29b97a:~# pip list --outdated | grep railroad-diagrams
railroad-diagrams 1.1.1   2.0.3  wheel

By adding python_requires=">= 3.7" to setup.py we could prevent this behavior precisely.

Signed-off-by: Wong Hoi Sing Edison [email protected]

From tabatkins@7fc0602
the minimal Python requirement `>= 3.7`, but https://pypi.org/project/railroad-diagrams/2.0.3/
is still availble from PIP for Ubuntu 18.04 + Python 3.6:

    root@748b3d29b97a:~# lsb_release -a
    LSB Version:    core-9.20170808ubuntu1-noarch:security-9.20170808ubuntu1-noarch
    Distributor ID: Ubuntu
    Description:    Ubuntu 18.04.6 LTS
    Release:    18.04
    Codename:   bionic

    root@748b3d29b97a:~# python3 --version
    Python 3.6.9

    root@748b3d29b97a:~# pip list --outdated | grep railroad-diagrams
    railroad-diagrams 1.1.1   2.0.3  wheel

By adding `python_requires=">= 3.7"` to `setup.py` we could prevent this
behavior precisely.

Signed-off-by: Wong Hoi Sing Edison <[email protected]>
@hswong3i hswong3i force-pushed the python_requires_gt_37 branch from 7267c30 to 469669e Compare June 24, 2022 00:40
@hswong3i
Copy link
Author

hswong3i commented Jun 24, 2022

Please also kindly yank 2.0.0, 2.0.1, 2.0.2 and 2.0.3 from https://pypi.org/project/railroad-diagrams/, if possible ;-)

@hswong3i
Copy link
Author

For now I give a quick dirty workaround with alvistack@b3ded95#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7, also manually disable https://build.opensuse.org/repositories/home:alvistack/tabatkins-railroad-diagrams-2.0.3 OBS build for any Python < 3.7 OS.

@tabatkins
Copy link
Owner

Right, I always forget you've got to update multiple things to let the nice computer know what versions you support. Sigh.

Okay, 2.0.4 released with a python_requires, and yanked the other 2.0.* versions.

@hswong3i
Copy link
Author

@tabatkins seems the changes didn't go to our GIT commit yet? But just changed locally and pushed to Pypi directly?

@tabatkins
Copy link
Owner

Sigh, yeah, pushed to GH now. ^_^

@hswong3i
Copy link
Author

@tabatkins yes get the commit from GH now ;-)

BTW, wish you a kindly consideration for #91, which could also simplify our life as downstream deb/rpm packager, and so we could also providing you feedback ASAP if case happened as this PR ;-)

@hswong3i hswong3i closed this Jun 24, 2022
@hswong3i hswong3i deleted the python_requires_gt_37 branch June 24, 2022 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants