Fix 1.5.1 regression in date conversion to/from java.sql.Date #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That commit was part of the work of adding the java.time types for 1.5.1 (issue #137). A potential for overflow in timezone handling for timestamps was corrected by changing the API of Timestamp_getTimeZone_id(). There was known to be one other use of that function, in Date.c. A comment was even added in Timestamp.h advising that there was a known use in Date.c. But somehow updating that known use in Date.c slipped through the cracks. The end result was that the new, preferable java.time API got added (preferable in part because it eliminates the unexpected timezone dependencies when manipulating local dates and times), but in the process a spooky timezone-dependent off-by-a-day error got introduced to the old date <-> java.sql.Date conversions.
jcflack
added a commit
that referenced
this pull request
Nov 5, 2018
Fix a regression in 1.5.1 that was not caught in pre-release testing, and could leave conversions between PostgreSQL date and java.sql.Date off by one day in certain timezones and times of the year (#199). Other issues in date/time conversion have also been uncovered that are of longer standing, not recent regressions. They are detailed in #200 and are not fixed in this PR, but can be addressed in another, later release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a regression in 1.5.1 that was not caught in pre-release testing, and could leave conversions between PostgreSQL
dateandjava.sql.Dateoff by one day in certain timezones and times of the year (#199).1.5.1 added support for the newer
java.timeclasses from JSR 310 / JDBC 4.2, which are recommended as superior alternatives to the older conversions involvingjava.sql.Dateand related classes. The new versions are superior in part because they do not have hidden timezone dependencies.However, the change to the historical
java.sql.Dateconversion behavior was inadvertent and needs to be fixed.Other issues in date/time conversion have also been uncovered that are of longer standing, not recent regressions. They are detailed in #200 and are not fixed in this PR, but can be addressed in another, later release.