Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target service variables to support https+insecure mode #14

Closed
wants to merge 3 commits into from

Conversation

campfred
Copy link

@campfred campfred commented Nov 9, 2023

Summary

Allows setting specific target mode and specific serving port as they're allowed to be changed in CLI.

What changed

  1. Edited serve/funnel commands in svc-tailscale-up/run script to use the <mode>:<port> <mode>://localhost:<port> syntax when using Serve.
  2. Introduced TAILSCALE_TARGET_MODE and TAILSCALE_TARGET_PORT variables for
  3. Edited README.md to reflect new variables and make it a bit easier to understand the Mode and Port variables descriptions

Justification

To enable supporting use cases like hosting a UniFi controller's web portal on a Tailnet which is normally self-signed https on 8443 (#13) and also to support allowing to set a custom port number within the allowed ones for the endpoint (docs).

Breaking change(s)

TAILSCALE_SERVE_PORT now addresses port number for the endpoint that is exposed on the Tailnet instead of the target service's port number.

@campfred
Copy link
Author

campfred commented Nov 9, 2023

Corrected a mistake from my part on an additional commit (c688947). I forgot the Funnel syntax. My apologies.

@campfred
Copy link
Author

Updated variable descriptions that had to do with Tailscale serving to tailnet/Internet to make it clearer on an additional commit (1960ad9). It is the result of having some more people test out my changes and providing feedback to me.

cwilson1776 pushed a commit to cwilson1776/docker-mod-tailscale that referenced this pull request Mar 2, 2024
cwilson1776 pushed a commit to cwilson1776/docker-mod-tailscale that referenced this pull request Mar 2, 2024
@campfred campfred closed this Mar 24, 2024
@campfred campfred deleted the feature/service-details branch March 24, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant