Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): add support for generators for upload body #207

Closed
wants to merge 0 commits into from

Conversation

langma
Copy link

@langma langma commented Sep 18, 2020

Add explicit support for generators, async and sync, to support other than
existing IOBase or file upload sources.

Fixes #206

@langma langma requested a review from TheKevJames as a code owner September 18, 2020 10:14
@langma langma force-pushed the feature/upload-generators branch 2 times, most recently from 35c4365 to efe8109 Compare September 18, 2020 10:53
@langma
Copy link
Author

langma commented Sep 18, 2020

I tried it locally and can say that the async version is behaving like I thought, allowing me to remove the boilerplate buffering code. However, I haven't tried with the REST version (although requests should also accept a Generator body). Also, I'm using python 3.8 and cannot easily test older versions.

@langma langma force-pushed the feature/upload-generators branch from efe8109 to 300ae16 Compare October 10, 2020 09:42
@langma langma closed this Oct 10, 2020
@langma langma force-pushed the feature/upload-generators branch from 300ae16 to b03711c Compare October 10, 2020 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

AsyncGenerator support in storage upload
1 participant