-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(3e -> 3a) Add InstanceGroup
class
#1618
Merged
roomrys
merged 44 commits into
liezl/add-method-to-match-instances-across-views
from
liezl/add-instance-group-class
Apr 12, 2024
Merged
Changes from 14 commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
cc4f1db
Add method to get single instance permutations
roomrys 7fd89ec
Clean-up
roomrys b9af5c3
Add method and (failing) test to get instance grouping
d89adff
Rename functions and add a per instance error function
8268a7c
Append a dummy instance for missing instances
2fbaf1f
Merge branch 'liezl/add-method-to-get-single-instance-permutations' o…
f7fd938
Update tests to accept a dummy instance
b863c6b
Correct 'permutations' to 'products'
8b73638
Merge branch 'liezl/add-method-to-get-single-instance-permutations' o…
c5001ea
Rename last few permutations to products
bd0f32d
Adapt instance grouping from single to multi instance
7ee80b0
Add function to get error per view
70bdc67
Add initial InstanceGroup class
roomrys ad5fb9e
Lint
roomrys 4037122
Lint
roomrys 89550a1
Few extra tests for `InstanceGroup`
roomrys 51f7fd3
Replace track-based triangulation with hypothesis-based
roomrys ab3b86d
Uncomment some commented out code (for testing)
roomrys 509e592
Merge branch 'liezl/add-method-for-multi-instance-products' of https:…
roomrys 5b40e9e
Fix typehinting, add comments
roomrys 2d1e23f
Merge branch 'liezl/add-method-for-multi-instance-products' of https:…
roomrys c66154a
Remember instance grouping after testing hypotheses
roomrys d5d6a43
Fix failing tests
roomrys c33ccc0
Merge branch 'liezl/add-method-to-match-instances-across-views' of ht…
roomrys 8ff1cc5
Typehinting
roomrys 892863b
Merge branch 'liezl/add-method-to-get-single-instance-permutations' o…
roomrys 1b21838
Typehinting
roomrys 134a83a
Merge branch 'liezl/add-method-to-test-instance-grouping' of https://…
roomrys a3aca14
Typehinting
roomrys 2e926d5
Merge branch 'liezl/add-method-for-multi-instance-products' of https:…
roomrys ae665ed
Typehinting
roomrys 5964e5d
Use reconsumable iterator for reprojected coords
roomrys aac86d5
Catch race condition early
roomrys 83aa558
Only triangulate user instances, add fixture, update tests
roomrys 2feb9f0
Lint
roomrys 38e37f2
Normalize instance reprojection errors
4a50c81
Merge branch 'liezl/add-method-to-match-instances-across-views' of ht…
roomrys 9a2fb9a
Add `locked`, `_dummy_instance`, `numpy`, and `update_points`
roomrys 8e0ceac
Allow `PredictedPoint`s to be updated as well
roomrys 0072f7a
Add tests for new attributes and methods
roomrys 01bbdad
Lint
roomrys 17e734c
Add methods to create, add, replace, and remove instances
95071c1
Use PredictedInstance for new/dummy instances
0c057c1
(3f -> 3e) Add `FrameGroup` class (#1665)
roomrys File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of
cast
to convertframe_idx
to an integer may not be safe ifframe_idx
can beNone
. Consider adding a check to ensureframe_idx
is notNone
before casting.