Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding documentation emphasizing GPU requirements (NIVIDA + Apple Silicon) #2071

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

ericleonardis
Copy link
Contributor

@ericleonardis ericleonardis commented Dec 19, 2024

Description

As requested in Issue #2016 I have added some up front documentation that makes it clearer that only NVIDIA GPUs and Apple Silicon Macs are supported. I added it to the installation documentation right at the top of the page under the installation widget as a note. Let me know if this is too bold, but should help to avoid those types of issues in the future.

Here is a screenshot of the installation docs:
installationscreenshot

I also added a Training Hardware Support section in the bottom of the Training Guide. Also I noticed that the training guide was not in the Guide menu, so I added Training With GUI to the guide menu as well.

Here is a screenshot of the Training guide and menu addition:
traininghardwaresupport

Types of changes

  • Bugfix
  • New feature
  • Refactor / Code style update (no logical changes)
  • Build / CI changes
  • Documentation Update
  • Other (explain)

Does this address any currently open issues?

[list open issues here]

Outside contributors checklist

  • Review the guidelines for contributing to this repository
  • Read and sign the CLA and add yourself to the authors list
  • Make sure you are making a pull request against the develop branch (not main). Also you should start your branch off develop
  • Add tests that prove your fix is effective or that your feature works
  • Add necessary documentation (if appropriate)

Thank you for contributing to SLEAP!

❤️

Summary by CodeRabbit

  • New Features

    • Added a new section on "Training Hardware Support" in the training documentation, detailing supported hardware configurations.
    • Updated the table of contents to include a link to the new training section.
  • Documentation

    • Enhanced installation documentation to clarify GPU support specifics and installation instructions.
    • Expanded guidance on using Mamba with package managers.
    • Updated initial training tutorial to specify hardware requirements for successful training and inference.

Copy link

coderabbitai bot commented Dec 19, 2024

Walkthrough

This pull request focuses on updating documentation across multiple files to improve clarity and accessibility of information about training hardware support and installation instructions for SLEAP. The changes include adding a new entry to the table of contents, creating a dedicated section on training hardware requirements, and providing more explicit guidance about GPU support for NVIDIA GPUs and Apple Silicon Macs.

Changes

File Change Summary
docs/guides/index.md Added training entry to the table of contents
docs/guides/training.rst Added new "Training Hardware Support" section detailing GPU and Mac compatibility
docs/installation.md Updated GPU support information, added note about Mamba package manager usage
docs/tutorials/initial-training.rst Clarified hardware requirements emphasizing the need for NVIDIA GPU or Apple Silicon Mac for TensorFlow

Possibly related PRs

Poem

🐰 A Rabbit's Guide to SLEAP's New Docs
With GPUs aligned and paths so clear,
NVIDIA and Apple, our training draws near!
Documentation sparkles, no mystery in sight,
A guide that makes learning an absolute delight!
🚀✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e67a59d and 7d089d1.

📒 Files selected for processing (1)
  • docs/tutorials/initial-training.rst (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • docs/tutorials/initial-training.rst

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
docs/guides/training.rst (1)

62-75: LGTM! Clear and comprehensive hardware support documentation.

The new section effectively communicates hardware requirements and limitations. Consider adding links to the installation guide for more detailed GPU setup instructions.

Add a reference to the installation guide:

 For best results, we recommend using an NVIDIA GPU or Apple Silicon Mac for training.
+
+For detailed GPU setup instructions, see the [Installation Guide](../installation.md#gpu-support).
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 66d96ce and 01481da.

📒 Files selected for processing (3)
  • docs/guides/index.md (1 hunks)
  • docs/guides/training.rst (2 hunks)
  • docs/installation.md (2 hunks)
🔇 Additional comments (2)
docs/guides/index.md (1)

46-46: LGTM! The training guide entry is properly added to the table of contents.

The addition improves documentation accessibility by making the training guide directly navigable.

docs/installation.md (1)

19-21: LGTM! Well-placed and clear GPU support information.

The note effectively communicates hardware requirements early in the installation process, helping users understand compatibility before proceeding with installation.

@ericleonardis
Copy link
Contributor Author

Actionable comments posted: 0

🧹 Nitpick comments (1)

docs/guides/training.rst (1)> 62-75: LGTM! Clear and comprehensive hardware support documentation.

The new section effectively communicates hardware requirements and limitations. Consider adding links to the installation guide for more detailed GPU setup instructions.
Add a reference to the installation guide:

 For best results, we recommend using an NVIDIA GPU or Apple Silicon Mac for training.
+
+For detailed GPU setup instructions, see the [Installation Guide](../installation.md#gpu-support).

This is a good suggestion, I made the changes and added the link to installation.md#gpu-support from the training guide rst.

@ericleonardis ericleonardis self-assigned this Dec 19, 2024
Copy link
Collaborator

@roomrys roomrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes yes, very good, thank you. Can we also add a note here:

This tutorial assumes you have a GPU in your local machine and that TensorFlow is able to use your GPU. If you don't have a GPU or you're having trouble getting it to work, you can run training and inference in the cloud. See our :ref:`colab` guide! Or take a look at our other :ref:`guides` about running SLEAP on remote machines.

Then, we will be good to go. Thanks!

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
docs/tutorials/initial-training.rst (1)

9-9: LGTM! Clear and well-positioned hardware requirements notice.

The note effectively communicates the supported hardware platforms and provides helpful alternatives for users without supported GPUs. The placement at the beginning of the tutorial is strategic and helps prevent users from running into issues later.

Consider enhancing the note with:

  1. Minimum GPU requirements (e.g., CUDA compute capability, minimum memory)
  2. Expected training performance differences between supported platforms
  3. Direct link to GPU setup instructions in the installation guide
    This tutorial assumes you have an NVIDIA GPU or an Apple Silicon Mac, and that TensorFlow is able to use your GPU. Training on other GPU architectures may fail. If you don't have a supported GPU or you're having trouble getting it to work, you can run training and inference in the cloud. See our :ref:`colab` guide! Or take a look at our other :ref:`guides` about running SLEAP on remote machines.
+
+    **Minimum Requirements:**
+    - NVIDIA GPU: CUDA compute capability 3.5 or higher, 8GB+ memory recommended
+    - Apple Silicon: M1/M2/M3 chip with 8GB+ memory
+
+    For detailed GPU setup instructions, see :ref:`gpu-setup`.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 819cba2 and e67a59d.

📒 Files selected for processing (1)
  • docs/tutorials/initial-training.rst (1 hunks)

@ericleonardis
Copy link
Contributor Author

Yes yes, very good, thank you. Can we also add a note here:

This tutorial assumes you have a GPU in your local machine and that TensorFlow is able to use your GPU. If you don't have a GPU or you're having trouble getting it to work, you can run training and inference in the cloud. See our :ref:`colab` guide! Or take a look at our other :ref:`guides` about running SLEAP on remote machines.

Then, we will be good to go. Thanks!

Done!

Here is the screenshot:

initialtraining

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants