-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: More E2E Tests #872
Open
shekohex
wants to merge
15
commits into
main
Choose a base branch
from
shady/restaking-e2e-02
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: More E2E Tests #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekohex
changed the title
feat: move erc20 transfer to its own shared crate
feat: More E2E Tests
Jan 7, 2025
Fixed some calls in the pallets, also this fixes an issue or bug in Closes #868
shekohex
force-pushed
the
shady/restaking-e2e-02
branch
from
January 9, 2025 13:28
d4c09fb
to
578064e
Compare
drewstone
reviewed
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
This pull request includes several changes to improve the handling of ERC20 assets, session management, and the overall functionality of the multi-asset delegation pallet. The most important changes include the addition of a new precompile utility, updates to session handling, and various refactorings to simplify the codebase and enhance functionality.
ERC20 Asset Handling Enhancements:
precompiles/erc20-utils
to the project (Cargo.toml
). [1] [2]process_execute_withdraw
function to handle ERC20 assets using precompiles and removed redundant EVM address handling. (pallets/multi-asset-delegation/src/functions/deposit.rs
) [1] [2]Session Management Improvements:
RoundChangeSessionManager
to handle round changes during new sessions. (pallets/multi-asset-delegation/src/lib.rs
)RoundChangeSessionManager
. (pallets/multi-asset-delegation/src/mock.rs
)Code Refactoring and Simplification:
pallet-session
andsp-staking
. (pallets/multi-asset-delegation/Cargo.toml
)handle_round_change
function and removed unnecessary return types. (pallets/multi-asset-delegation/src/functions/session_manager.rs
) [1] [2]New Functionalities:
ready_withdraw_requests
to return an iterator over withdraw requests ready for execution. (pallets/multi-asset-delegation/src/functions/deposit.rs
)pallets/multi-asset-delegation/src/tests/session_manager.rs
)Minor Changes:
fast-runtime
feature in the end-to-end test suite. (.github/workflows/checks.yml
)pallets/multi-asset-delegation/src/functions.rs
)Implemented test cases
Reference issue to close (if applicable)
Closes #868
Part of #861