Support c++20 and clang compiler #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewdzzz
force-pushed
the
support-c++20
branch
15 times, most recently
from
cb0a126 to
27a49a3
Compare
drewdzzz
force-pushed
the
support-c++20
branch
8 times, most recently
from
3553cb3 to
4c07c6c
Compare
drewdzzz
force-pushed
the
support-c++20
branch
6 times, most recently
from
014e902 to
c7f5ba6
Compare
Apparently, this type only exists in std namespace on clang.
This function was static in header so the warning "static function defined in header must be inline" on clang was triggered. Let's make this function private static method of libev - it will hide this non-public function and solve the problem with warning.
Because of this, the project's build using clang was failing. The header is required to use `uint*_t` types.
Pre-installed compilers are used, building with a compiler of particular versions is not tested. GCC on MacOS is not tested since it is pointless - it is just an alias for clang there. There was a problem in the way - ubuntu-22.04 runner has incompatible clang and stdlibc++ versions. As an outcome, tntcxx build with clang and c++20 standard fails, link to the corresponding issue can be found in a workflow file. In order to work this problem around, let's remove g++-13 and install g++-12 on this runner, which has compatible library version.
drewdzzz
force-pushed
the
support-c++20
branch
2 times, most recently
from
370d554 to
63fb239
Compare
The job only builds the connector, without setting up Tarantool and testing tntcxx. It is used to check building with different compilers and c++ standards.
The linter asked me to make them sorted.
The commit makes clang-format config more suitable to our codebase.
drewdzzz
force-pushed
the
support-c++20
branch
from
63fb239 to
f9e2f1c
Compare
Clang format can return "clang-format did not modify any files" - let's support this string.
drewdzzz
force-pushed
the
support-c++20
branch
from
f9e2f1c to
225ad6f
Compare
It is required to test tntcxx with undefined behavior sanitizer, which is disabled on GCC because of bug. Closes tarantool#73
CuriousGeorgiy
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
I would still prefer using specific compiler versions in CI (fine to use the default available compiler versions). Up to @alyapunov.
drewdzzz
force-pushed
the
support-c++20
branch
2 times, most recently
from
3e4dc90 to
b04171e
Compare
|
@CuriousGeorgiy |
In brew, new stable version of Tarantool is 3.0.0. It has a new feature: case-sensitive names in SQL. So let's make ClientTest version-independent and call SQL columns in upper case. Along the way, let's print response sql metadata in ClientTest - it will make it easy to find a problem if the test fails.
drewdzzz
force-pushed
the
support-c++20
branch
from
b04171e to
c818e84
Compare
|
I've spent some time trying to fix this linter error, but I haven't found anything. Let's just ignore it. |
I think we should have a goal to build on any compiler (perhaps starting from certain version). But we cannot test any compiler. I think the best thing we can do is to build with unspecified (perhaps latest) compiler version in order to have a change to detect build problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch adds support of C++20 and clang compiler. Along the way, fixes some clang-format problems.
Note that we don't test Tarantool build with particular clang or gcc versions - default ones from Github runners are used.
Since we support clang compiler, the patch enables undefined behavior sanitizers (#73)
Closes #85
Closes #73