Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: update README.md #95

Merged
merged 1 commit into from
Oct 15, 2024
Merged

readme: update README.md #95

merged 1 commit into from
Oct 15, 2024

Conversation

drewdzzz
Copy link
Collaborator

The commit completely rewrites decoding section since the decoder was reworked. Along the way, commit marks all snippets as c++ code and fixes some mild inconveniences.

Closes #94

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@CuriousGeorgiy CuriousGeorgiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I would split into several commits:

  1. Annotation of code snippets with c++.
  2. Drop of dead examples
  3. Updates to relevant examples.

But this is just a README, so doesn't really matter.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@CuriousGeorgiy CuriousGeorgiy removed their assignment Oct 11, 2024
@mkostoevr mkostoevr removed their assignment Oct 14, 2024
The commit completely rewrites decoding section since the decoder was
reworked. Along the way, commit marks all snippets as `c++` code and
drops `conn.status.is_failed` from docs since it doesn't exist anymore.

Closes tarantool#94
@drewdzzz drewdzzz merged commit fcf86e5 into tarantool:master Oct 15, 2024
27 of 38 checks passed
@drewdzzz drewdzzz deleted the readme_fix branch October 15, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revise Outdated Content in README.md
3 participants