Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated packet_source to fix bug with BlackBodySimpleSource.create_pa… #2962

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nvieira-mcgill
Copy link

Updated packet_source to fix bug with BlackBodySimpleSource.create_packets() to take args and kwargs

Resolves #2953

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

@tardis-bot
Copy link
Contributor

*beep* *bop*
Hi human,
I ran ruff on the latest commit (59b9500).
Here are the outputs produced.
Results can also be downloaded as artifacts here.
Summarised output:

1	RET505	Unnecessary `else` after `return` statement

Complete output(might be large):

tardis/transport/montecarlo/packet_source.py:246:9: RET505 Unnecessary `else` after `return` statement
Found 1 error.

@andrewfullard
Copy link
Contributor

andrewfullard commented Feb 3, 2025

Apologies for the errors. So that tests can run, please push an empty commit with git commit --allow-empty -m "Trigger workflows"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not accepting args/kwargs in BlackBodySimpleSourceRelativistic.create_packets()
4 participants