pkp#10759 Remove orcidReviewPutCode from User schema, and fix invalid…

… header reference in DepositOrcidSubmission
taslangraham · Jan 7, 2025 · fed6e1a · fed6e1a
1 parent 72e802d
commit fed6e1a
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 9 deletions.
diff --git a/classes/orcid/PKPOrcidWork.php b/classes/orcid/PKPOrcidWork.php
@@ -65,7 +65,7 @@ private function build(): array
             $this->context->getPath(),
             'article',
             'view',
-            $submission->getId(),
+            [$submission->getId()],
             urlLocaleForPage: '',
         );
 

diff --git a/jobs/orcid/DepositOrcidSubmission.php b/jobs/orcid/DepositOrcidSubmission.php
@@ -95,7 +95,7 @@ public function handle(): void
                 OrcidManager::logInfo("Work updated in profile, putCode: {$putCode}");
                 break;
             case 201:
-                $location = $responseHeaders['Location'][0];
+                $location = $responseHeaders['location'][0];
                 // Extract the ORCID work put code for updates/deletion.
                 $putCode = intval(basename(parse_url($location, PHP_URL_PATH)));
                 OrcidManager::logInfo("Work added to profile, putCode: {$putCode}");

diff --git a/schemas/user.json b/schemas/user.json
@@ -287,13 +287,6 @@
 				"nullable"
 			]
 		},
-		"orcidReviewPutCode": {
-			"type": "string",
-			"apiSummary": true,
-			"validation": [
-				"nullable"
-			]
-		},
 		"rememberToken": {
 			"type": "string",
 			"writeOnly": true,