Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TI-427: Add compatibility with Grape 2.2 #9

Closed
wants to merge 1 commit into from
Closed

TI-427: Add compatibility with Grape 2.2 #9

wants to merge 1 commit into from

Conversation

zengraf
Copy link

@zengraf zengraf commented Oct 24, 2024

@zengraf zengraf requested review from dmoss18 and a team October 24, 2024 07:16
@zengraf zengraf marked this pull request as ready for review October 24, 2024 07:16
@maxemitchell
Copy link

Could you include the context around why we forked in the first place?

@dmoss18
Copy link

dmoss18 commented Oct 24, 2024

We could consider merging new changes from the origin branch instead of copy pasting them here

@zengraf
Copy link
Author

zengraf commented Oct 25, 2024 •
edited
Loading

@maxemitchell, I think it was done to add the functionality of hiding all endpoints by default, as it is not present in the original gem.

@dmoss18, sure, I opened the PR #11. I initially thought that there would be lots of conflicts, but there were not that many.

@zengraf
Copy link
Author

zengraf commented Oct 29, 2024

Resolved with #11

@zengraf zengraf closed this Oct 29, 2024
@zengraf zengraf deleted the TI-427_grape-2.2 branch October 29, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmoss18 dmoss18 Awaiting requested review from dmoss18

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zengraf @maxemitchell @dmoss18