Use the AOs introduced by the modules host hooks refactor #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
force-pushed
the
use-new-hooks
branch
3 times, most recently
from
34d0247 to
d4f1857
Compare
nicolo-ribaudo
force-pushed
the
use-new-hooks
branch
from
d4f1857 to
8cda3bc
Compare
Jack-Works
reviewed
Sep 20, 2022
spec.emu
Outdated
| <h1>Runtime Semantics: Evaluation</h1> | ||
| <emu-grammar>ModuleBlockExpression: `module` `{` ModuleBody `}`</emu-grammar> | ||
| <emu-alg> | ||
| 1. Let _moduleBlock_ be OrdinaryObjectCreate(%ModuleBlock.prototype%, « [[ModuleRecord]], [[SourceText]] »). |
There was a problem hiding this comment.
don't we use the %Module.prototype% from https://tc39.es/proposal-compartments/0-module-and-module-source.html#sec-module-constructor?
There was a problem hiding this comment.
Yes, the proposal just needs to be made compatible with the compartments one. I plan to do as soon as this is merged.
|
tc39/ecma262#2905 hasn't been merged yet, but I added an This PR can be reviewed; it might be easier to review it at https://raw.githack.com/tc39/proposal-js-module-blocks/aecaef48e8245def3af5c219767cfd419b27a379/index.html (as if it was a completely new spec) rather than as a diff. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the proposal on top of tc39/ecma262#2905. While the syntax has not changed (it has been indented; you can disable whitespace diff when reviewing), the runtime algorithms have been rewritten from scratch.
I'm marking this as draft, since tc39/ecma262#2905 hasn't been properly reviewed yet.Readable version: https://raw.githack.com/tc39/proposal-js-module-blocks/aecaef48e8245def3af5c219767cfd419b27a379/index.html