Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User stats match and history #121

Merged
merged 10 commits into from
Jan 31, 2024
Merged

User stats match and history #121

merged 10 commits into from
Jan 31, 2024

Conversation

hferraud
Copy link
Collaborator

Add a /match/ endpoint to post matches and a /user/{id}/history/ endpoint to get the history with pagination, see documentation.

@hferraud hferraud self-assigned this Jan 31, 2024
@hferraud hferraud linked an issue Jan 31, 2024 that may be closed by this pull request
Error on user_stats authentication using the common folder #118
Closed
@tdameros tdameros self-requested a review January 31, 2024 01:43
tdameros
tdameros approved these changes Jan 31, 2024
View reviewed changes
Copy link
Owner

@tdameros tdameros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to rename the endpoints using the microservice name in a future pull request.

@hferraud
Copy link
Collaborator Author

Don't forget to rename the endpoints using the microservice name in a future pull request.

#123

@hferraud hferraud mentioned this pull request Jan 31, 2024
Closed
V-Fries
V-Fries approved these changes Jan 31, 2024
View reviewed changes
user_stats/src/user_stats/settings.py
]

CORS_ALLOWED_ORIGINS = ['https://*']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For allow all, please use :

CORS_ALLOW_ALL_ORIGINS = True
CORS_ALLOWED_ORIGINS = ['*']

#117 (comment)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3509666

V-Fries
V-Fries requested changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@V-Fries V-Fries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comment above, I clicked approve accidentally

@hferraud hferraud merged commit a6bcf35 into main Jan 31, 2024
5 checks passed
@hferraud hferraud deleted the user-stats-games branch January 31, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdameros tdameros tdameros approved these changes

@V-Fries V-Fries V-Fries approved these changes

@a-levra a-levra Awaiting requested review from a-levra

@EthanDelage EthanDelage Awaiting requested review from EthanDelage

Assignees

@hferraud hferraud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error on user_stats authentication using the common folder
3 participants
@hferraud @tdameros @V-Fries