Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove registration deadline in tournament #149

Merged
merged 2 commits into from
Feb 3, 2024
Merged

Remove registration deadline in tournament #149

merged 2 commits into from
Feb 3, 2024

Conversation

EthanDelage
Copy link
Collaborator

No description provided.

@EthanDelage EthanDelage linked an issue Feb 3, 2024 that may be closed by this pull request
Delete registration deadline in tournament #148
Closed
a-levra
a-levra approved these changes Feb 3, 2024
View reviewed changes
Copy link
Collaborator

@a-levra a-levra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but did you just want to make things simpler or was this causing a real issue ?

@tdameros
Copy link
Owner

tdameros commented Feb 3, 2024

OK, but did you just want to make things simpler or was this causing a real issue ?

I asked him to disable it because it requires a lot of work to implement on the front end.

@EthanDelage EthanDelage merged commit 5319547 into main Feb 3, 2024
5 checks passed
@EthanDelage EthanDelage deleted the 148-delete-registration-deadline-in-tournament branch February 3, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdameros tdameros tdameros approved these changes

@a-levra a-levra a-levra approved these changes

@hferraud hferraud Awaiting requested review from hferraud

@V-Fries V-Fries Awaiting requested review from V-Fries

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete registration deadline in tournament
3 participants
@EthanDelage @tdameros @a-levra