Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bluesky data field for conferences #7515

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

JoshuaKGoldberg
Copy link
Contributor

Thanks for creating a new Pull Request for this repository.

To get the conference as fast as possible into confs.tech please consider the following things.

Checklist for your change

  • does not delete another conference
  • has passed the tests via npm run test
  • has the correct order via npm run reorder-confs
  • is a developer conference: more than 3-4 people from different companies
  • is not a webinar, hackathon, marketing, zoom meeting with one person
  • URLs are reachable, as short as possible, do not contain tracking parameters and the website is dedicated for this event
  • topic is correct
  • conference name is as short as possible and does not include location and date

(this isn't adding a conf, but hey - it still passes the checklist anyway!)


Fixes #7509 on this repo's end. I'll send separate PRs for the other repos too.

Just pipes the data through without adding any validations. I considered adding one to script/utils/checkConference.ts but 🤷 I'm not positive on the right way to validate a bsky handle.

@cgrail
Copy link
Member

cgrail commented Jan 24, 2025

Looks good. Did you also change the order in the other stacks?

@cgrail cgrail merged commit d9bb679 into tech-conferences:main Jan 24, 2025
2 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the bluesky-data branch January 24, 2025 21:56
@JoshuaKGoldberg
Copy link
Contributor Author

Wow you reviewed this fast 😄 I got up from the computer, made a latte, and it was merged. I haven't done anything yet. Working on it now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Bluesky data
2 participants