Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: functional tests with a set of predefined questions + route for counting docs #37

Merged
merged 6 commits into from
Nov 23, 2023

Conversation

Jaszkowic
Copy link
Contributor

@Jaszkowic Jaszkowic commented Nov 23, 2023

For every predefined question:

  • Set question to API (with flag generate_answer = false because we are only interested in the search results, not in the answer generation), wait for response
  • Check if document is included in the response matches

Copy link

render bot commented Nov 23, 2023

@Jaszkowic Jaszkowic marked this pull request as ready for review November 23, 2023 11:26
@Jaszkowic Jaszkowic requested a review from ff6347 as a code owner November 23, 2023 11:26
@Jaszkowic Jaszkowic changed the title feat: functional tests with a set of predefined questions feat: functional tests with a set of predefined questions + route for counting docs Nov 23, 2023
@Jaszkowic
Copy link
Contributor Author

sorry for putting two features in one PR 😇 but I'm too lazy to now make two PRs out of that

@Jaszkowic Jaszkowic merged commit 9c0019c into main Nov 23, 2023
6 checks passed
@Jaszkowic Jaszkowic deleted the feat/api-tests branch November 23, 2023 11:29
tsboter pushed a commit that referenced this pull request Nov 23, 2023
# [1.11.0](v1.10.0...v1.11.0) (2023-11-23)

### Features

* functional tests with a set of predefined questions + route for counting docs ([#37](#37)) ([9c0019c](9c0019c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant