Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated twitter logo #63

Closed
wants to merge 3 commits into from
Closed

Conversation

vedhcet-07
Copy link

Sir this issue was simple , but not assigned to me nor anyone . Since it was simple i rectified and directly submitted PR .

Sir if everything is correct please accept it under gssoc and hacktoberfest . If any changes let me know .

Thank you

Copy link

vercel bot commented Oct 10, 2024

@vedhcet-07 is attempting to deploy a commit to the Tejas Nasre's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Boom! Your pull request just flew into the Nexmeet HQ. High fives all around! Our team of tech wizards will check it out and get back to you faster than you can say 'code ninja!' Thanks for leveling up the project!

@tejasnasre
Copy link
Owner

its not correct way to make the PR bro your are not assigned the issue still make PR and the useless issue i think you are contributing first time its okay but don't do this stuff in other project

Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nexmeet ❌ Failed (Inspect) Oct 10, 2024 2:22pm

@vedhcet-07
Copy link
Author

its not correct way to make the PR bro your are not assigned the issue still make PR and the useless issue i think you are contributing first time its okay but don't do this stuff in other project

First of all sorry sir . Yea its my first time . Ok i get it its a useless issue , but i though thought it matters , i accept it its my mistake. I will make sure that I wont repeat the same in other projects .

Thank you

@tejasnasre tejasnasre added gssoc-ext gssoc extended hacktoberfest-accepted hacktoberfest accepted hacktoberfest Hacktoberfest 2024 level 1 level 1 - beginner issue labels Oct 10, 2024
@tejasnasre
Copy link
Owner

tejasnasre commented Oct 10, 2024

change the logo in explore-events/a97133a9-5e03-49e3-aff3-6604bed83fdb share btn then i will merge

@vedhcet-07
Copy link
Author

change the logo in explore-events/a97133a9-5e03-49e3-aff3-6604bed83fdb share btn then i will merge

ok sir i am checking into it . Thanks for giving a opportunity

Changed all x logo
@vedhcet-07
Copy link
Author

change the logo in explore-events/a97133a9-5e03-49e3-aff3-6604bed83fdb share btn then i will merge

Boss i have figured it out and pls review it . Let me know if anything . Thank you

@tejasnasre
Copy link
Owner

change the logo in explore-events/a97133a9-5e03-49e3-aff3-6604bed83fdb share btn then i will merge

Boss i have figured it out and pls review it . Let me know if anything . Thank you

run : npm run build the deployment got errors

@vedhcet-07
Copy link
Author

change the logo in explore-events/a97133a9-5e03-49e3-aff3-6604bed83fdb share btn then i will merge

Boss i have figured it out and pls review it . Let me know if anything . Thank you

run : npm run build the deployment got errors

sir i dont know why did this happen . i just changed logos . You can verify the things which i changed

@tejasnasre
Copy link
Owner

solve error if i check i will not merge this PR

@vedhcet-07 vedhcet-07 changed the base branch from main to dev October 10, 2024 15:20
@vedhcet-07
Copy link
Author

sir i dk why it happened . but i will try again . give me some time . i will do from beginning again.

@vedhcet-07 vedhcet-07 closed this Oct 10, 2024
@vedhcet-07 vedhcet-07 deleted the twitter-logo branch October 10, 2024 15:44
@tejasnasre tejasnasre added invalid This doesn't seem right and removed gssoc-ext gssoc extended hacktoberfest-accepted hacktoberfest accepted level 1 level 1 - beginner issue hacktoberfest Hacktoberfest 2024 labels Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants