Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation For Request Booking At Event Space #70

Merged
merged 3 commits into from
Oct 12, 2024

Conversation

rudrapratap63
Copy link
Contributor

Fix #49

check the walkthrough video :

NexMeet-Request.Booking.mp4

Copy link

vercel bot commented Oct 10, 2024

@rudrapratap63 is attempting to deploy a commit to the Tejas Nasre's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Boom! Your pull request just flew into the Nexmeet HQ. High fives all around! Our team of tech wizards will check it out and get back to you faster than you can say 'code ninja!' Thanks for leveling up the project!

@rudrapratap63
Copy link
Contributor Author

@tejasnasre , please check the PR and If you would like any other changes, let me know.

@rudrapratap63
Copy link
Contributor Author

@tejasnasre , please check the PR. I have now redirected the user to the dashboard when they click the request-booking button.

@tejasnasre
Copy link
Owner

src/app/(event-space)/explore-event-space/[spaceId]/page.tsx here why you are wrote redirection link like this router.push(/explore-event-space/request-booking?spaceId=${spaceId}); just write router.push(/register-event/${spaceId}); is there any difference ? and the data your are taking don't show sapceId in form and organizerId take organiserId will be email we just need date and submit btn the status will be update by admin

@tejasnasre
Copy link
Owner

update the things here i will merge it soon

Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nexmeet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2024 6:53pm

@tejasnasre tejasnasre added enhancement New feature or request gssoc-ext gssoc extended hacktoberfest-accepted hacktoberfest accepted level 2 level 2 - intermediate issue hacktoberfest Hacktoberfest 2024 labels Oct 11, 2024
@rudrapratap63
Copy link
Contributor Author

@tejasnasre , the routes router.push(/explore-event-space/request-booking?spaceId=${spaceId}) and router.push(/register-event/${spaceId}) are different. If we redirect the user to /register-event/${spaceId}, they will be taken to this page:

image

On the other hand, for the "request event space" functionality, I have created a new page:
image

If I'm mistaken, please correct me.

@rudrapratap63
Copy link
Contributor Author

and the data your are taking don't show sapceId in form and organizerId take organiserId will be email we just need date and submit btn the status will be update by admin

Could you please explain this in more detail? I'm feeling a bit confused.

@tejasnasre
Copy link
Owner

@tejasnasre , the routes router.push(/explore-event-space/request-booking?spaceId=${spaceId}) and router.push(/register-event/${spaceId}) are different. If we redirect the user to /register-event/${spaceId}, they will be taken to this page:

image
i know i am talking about format '/explore-event-space/request-booking/{id}`

@tejasnasre
Copy link
Owner

On the other hand, for the "request event space" functionality, I have created a new page: image

If I'm mistaken, please correct me.
here take only date and submit the organizerid is email don't post actual id and email will fetched directly with use details right but add with id don't show there

@tejasnasre
Copy link
Owner

any updates

@rudrapratap63
Copy link
Contributor Author

Hi @tejasnasre , I apologize for the delay. I had a fever, which slowed down my progress. However, I’m feeling better now and will update the PR and complete my work today.

@tejasnasre
Copy link
Owner

Hi @tejasnasre , I apologize for the delay. I had a fever, which slowed down my progress. However, I’m feeling better now and will update the PR and complete my work today.

yeah no worries

@rudrapratap63
Copy link
Contributor Author

@tejasnasre Please check: I have removed the organiser ID input and now use the organiser's email for the ID. Additionally, I have removed the spaceId and status inputs, set the status to 'pending,' which will be approved by the admin.

image

In supabase value stored like this:
image

@tejasnasre
Copy link
Owner

great post video with working db and this frontend and add info to Learn.md i will merge it soon

@rudrapratap63
Copy link
Contributor Author

@tejasnasre okay i will do it 👍

@rudrapratap63
Copy link
Contributor Author

@tejasnasre, could you please advise on what should be included in the learn.md? Also, please review the video below that shows the frontend and the working database:

nexmeet-updated.mp4

@rudrapratap63
Copy link
Contributor Author

@tejasnasre Sir, please review the PR. I don't believe it's necessary to update the learn.md file, as I haven't made any changes that would require it. However, if you think any updates are needed, please let me know.

@tejasnasre
Copy link
Owner

all good we already have definition language no need to change anything i will merge

@tejasnasre tejasnasre merged commit 36882cb into tejasnasre:dev Oct 12, 2024
4 checks passed
@rudrapratap63
Copy link
Contributor Author

@tejasnasre Sir, if you have any other contribution tasks for me, please let me know.

@tejasnasre
Copy link
Owner

@tejasnasre Sir, if you have any other contribution tasks for me, please let me know.

Thanks for contribution, we have lot of issues or you can make meaningful issues

@rudrapratap63
Copy link
Contributor Author

@tejasnasre Sir, if you have any other issue in mind, then could you please suggest some Level 3 issues for my next contribution?

@tejasnasre
Copy link
Owner

@tejasnasre Sir, if you have any other issue in mind, then could you please suggest some Level 3 issues for my next contribution?

Yeah we need new feature that If you add your own event it should require admin approve the event will show in explore page if you can solve this go ahead

@tejasnasre
Copy link
Owner

By this the Spam event will not there and in production it will help us to authenticate the event

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc-ext gssoc extended hacktoberfest Hacktoberfest 2024 hacktoberfest-accepted hacktoberfest accepted level 2 level 2 - intermediate issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants