Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup legacy content #2

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Cleanup legacy content #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions .github/PULL_REQUEST_TEMPLATE/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,20 @@ your descriptive commit message(s)! -->
These are the criteria that every PR should meet, please check them off as you
review them:

- [ ] Follows the [authoring recommendations][authoring]
- [ ] Follows the [authoring recommendations](../../recommendations.md)
- [ ] Includes [docs][docs] (if user facing)
- [ ] Includes [tests][tests] (for new tasks or changed functionality)
- See the [end-to-end testing documentation][e2e] for guidance and CI details.
- See the [automated testing documentation][e2e] for guidance and CI details.
- [ ] Meets the [Tekton contributor standards][contributor] (including functionality, content, code)
- [ ] Commit messages follow [commit message best practices][commit]
- [ ] Has a kind label. You can add one by adding a comment on this PR that
contains `/kind <type>`. Valid types are bug, cleanup, design, documentation,
feature, flake, misc, question, tep
- [ ] Complies with [Catalog Organization TEP][TEP], see [example]. **Note** [An issue has been filed to automate this validation][validation]
- [ ] File path follows `<kind>/<name>/<version>/name.yaml`
- [ ] Has `README.md` at `<kind>/<name>/<version>/README.md`
- [ ] File path follows `<kind>/<name>/name.yaml`
- [ ] Has `README.md` at `<kind>/<name>/README.md`
- [ ] Has mandatory `metadata.labels` - `app.kubernetes.io/version` the same as the `<version>` of the resource
- The `<version>` should follow semantic versioning strategy (e.g. `<major>.<minor>.<patch>`)
- [ ] Has mandatory `metadata.annotations` `tekton.dev/pipelines.minVersion`
- [ ] mandatory `spec.description` follows the convention

Expand All @@ -35,14 +36,15 @@ review them:
Paragraph(s) to describe the resource.
```

_See [the contribution guide](https://github.com/tektoncd/catalog/blob/master/CONTRIBUTING.md) for more details._
_See [the contribution guide][catalog-contributor] for more details._

[TEP]: https://github.com/tektoncd/community/blob/master/teps/0003-tekton-catalog-organization.md
[example]: https://github.com/tektoncd/catalog/tree/master/task/git-clone/0.1
[example]: https://github.com/tektoncd-catalog/golang
[validation]: https://github.com/tektoncd/catalog/issues/413
[authoring]: https://github.com/tektoncd/catalog/blob/main/recommendations.md
[docs]: https://github.com/tektoncd/community/blob/master/standards.md#docs
[tests]: https://github.com/tektoncd/community/blob/master/standards.md#tests
[e2e]: https://github.com/tektoncd/catalog/blob/main/CONTRIBUTING.md#end-to-end-testing
[e2e]: ../../CONTRIBUTING.md#automated-testing
[contributor]: https://github.com/tektoncd/community/blob/main/standards.md
[commit]: https://github.com/tektoncd/community/blob/master/standards.md#commit-messages
[commit]: https://github.com/tektoncd/community/blob/master/standards.md#commits
[catalog-contributor]: ../../CONTRIBUTING.md
Loading