Migrate golang-build and golang-test resources #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Part of #3 |
vinamra28
reviewed
Jan 14, 2023
vinamra28
reviewed
Jan 14, 2023
task/golang-build/OWNERS
Outdated
Comment on lines
1
to
4
| approvers: | ||
| - vdemeester | ||
| reviewers: | ||
| - vdemeester |
There was a problem hiding this comment.
should we add all the maintainers of current catalog here?
There was a problem hiding this comment.
Yeah, I did some further investigation. For reviewers we just need to add the name to the org.yaml file in the community repo: tektoncd/community#933.
For the approvers we need both the name in the org.yaml file and in the approvers list in this OWNERS file. So I removed the reviewers list in this file and added all maintainers to the approvers list. PTAL 😁
|
/documentation |
QuanZhang-William
added
documentation
This commit - Migrated the [golang-build][golang-build] and [golang-test][golang-test] tasks from the central repo - Changed the `app.kubernetes.io/version` to `1.0.0` - Added new annotations required in [tep-0079][tep-0079] The tests will be updated and migrated in later PRs, the installation in the README.md file will be updated in later PRs. [golang-build]: https://github.com/tektoncd/catalog/tree/main/task/golang-build/0.3 [golang-test]: https://github.com/tektoncd/catalog/tree/main/task/golang-test/0.2 [tep-0079]: https://github.com/tektoncd/community/blob/main/teps/0079-tekton-catalog-support-tiers.md#cluster
QuanZhang-William
force-pushed
the
migrate-resources
branch
from
06ec727 to
07f2cf2
Compare
|
testing purpose: /lgtm |
vinamra28
approved these changes
Jan 16, 2023
10 tasks
|
/lgtm |
QuanZhang-William
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit
app.kubernetes.io/versionto1.0.0The tests will be updated and migrated in later PRs, the installation in the README.md file will be updated in later PRs.