Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add golang verified catalog integration test infra #1340

Closed
wants to merge 1 commit into from
Closed

Add golang verified catalog integration test infra #1340

wants to merge 1 commit into from

Conversation

QuanZhang-William
Copy link
Member

This commit adds the integration test infra for the golang verified catalog using kind-e2e pipeline.

This commit follows the automated testing proposal in tep-0079, creating 2 integration tests on before PR merge:

  • pull-tekton-catalog-integration-tests-latest which executes the catalog test cases against the latest release of Tekton Pipeline (specified in the test/e2e-tests-latest-pipeline-ver.env file of the target catalog).
  • pull-tekton-catalog-integration-tests-min-compatible which executes the catalog test cases against the catalog's min compatible version of the Tekton Pipeline (specified in the test/e2e-tests-min-compatible-pipeline-ver.env file of the target catalog).

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 6, 2023
@QuanZhang-William
Copy link
Member Author

/hold until #1334 is tested

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2023
@QuanZhang-William
Copy link
Member Author

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 6, 2023
@QuanZhang-William QuanZhang-William mentioned this pull request Feb 6, 2023
Closed
5 tasks
@QuanZhang-William QuanZhang-William marked this pull request as draft February 7, 2023 20:01
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 7, 2023
@QuanZhang-William
Copy link
Member Author

@afrittoli not sure if we should proceed with this PR since #1292 is still on hold? 🤔

@QuanZhang-William
Add golang verified catalog integration test infra
b6e74b2 
This commit adds the integration test infra for the [golang][golang] verified catalog using [kind-e2e][kind] pipeline.

This commit follows the automated testing proposal in [tep-0079][tep-0079], creating 2 integration tests on before PR merge:

  - `pull-tekton-catalog-integration-tests-latest` which executes the catalog test cases against the latest release of Tekton Pipeline (specified in the `test/e2e-tests-latest-pipeline-ver.env` file of the target catalog).
  - `pull-tekton-catalog-integration-tests-min-compatible` which executes the catalog test cases against the catalog's min compatible version of the Tekton Pipeline (specified in the `test/e2e-tests-min-compatible-pipeline-ver.env` file of the target catalog).

[golang]: https://github.com/tektoncd-catalog/golang
[tep-0079]: https://github.com/tektoncd/community/blob/main/teps/0079-tekton-catalog-support-tiers.md#automated-testing-and-dogfooding-1
[kind]: https://github.com/tektoncd/plumbing/blob/main/tekton/ci/jobs/e2e-kind.yaml
@QuanZhang-William QuanZhang-William force-pushed the verified-golang-catalog-integration-test branch from d38db88 to b6e74b2 Compare February 15, 2023 12:09
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2023
@QuanZhang-William
Copy link
Member Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2023
@QuanZhang-William QuanZhang-William marked this pull request as ready for review February 17, 2023 14:29
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 17, 2023
@tekton-robot tekton-robot requested review from jerop and wlynch February 17, 2023 14:29
@QuanZhang-William QuanZhang-William marked this pull request as draft February 17, 2023 14:36
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 17, 2023
@QuanZhang-William QuanZhang-William mentioned this pull request Feb 21, 2023
Open
10 tasks
@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 18, 2023
@tekton-robot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 17, 2023
@tekton-robot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Contributor

@tekton-robot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@dlorenc dlorenc Awaiting requested review from dlorenc

@jerop jerop Awaiting requested review from jerop

@wlynch wlynch Awaiting requested review from wlynch

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QuanZhang-William @tekton-robot @vdemeester