-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/include entity id and type as measures when ngsi payload #807
Merged
mrutid
merged 12 commits into
master
from
task/include_entity_id_and_type_as_measures_when_ngsi_payload
Jan 30, 2024
Merged
Task/include entity id and type as measures when ngsi payload #807
mrutid
merged 12 commits into
master
from
task/include_entity_id_and_type_as_measures_when_ngsi_payload
Jan 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s_when_ngsi_payload
mrutid
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mrutid
deleted the
task/include_entity_id_and_type_as_measures_when_ngsi_payload
branch
January 30, 2024 08:38
fgalan
reviewed
Jan 30, 2024
valuesEntity.push({ | ||
name: constants.NGSI + k, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The NGSI constant should be removed from constant.js file, shouldn't it?
AlvaroVega
restored the
task/include_entity_id_and_type_as_measures_when_ngsi_payload
branch
January 30, 2024 08:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of PR #804
Given a ngsiv2 measure like:
id and type from entity ( "id": "urn:ngsiv2:Streetlight:Streetlight-Mylightpoint-2" and "type": "Streetlight",) are progressing as measures to iotagent using prefix ngsiv2_id and ngsiv2_type respectively: