-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to API route /iot/groups
(/iot/services
still supported)
#342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapedraza
changed the title
Add support to API route
[WIP] Add support to API route Aug 27, 2024
/iot/groups
(/iot/services
still supported)/iot/groups
(/iot/services
still supported)
Pull Request Test Coverage Report for Build 10580644434Details
💛 - Coveralls |
mapedraza
changed the title
[WIP] Add support to API route
Add support to API route Aug 27, 2024
/iot/groups
(/iot/services
still supported)/iot/groups
(/iot/services
still supported)
fgalan
reviewed
Aug 27, 2024
Co-authored-by: Fermín Galán Márquez <[email protected]>
fgalan
reviewed
Aug 27, 2024
fgalan
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Passing ball to @AlvaroVega for additional LGTM before merging.
AlvaroVega
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix #270
This PR overpass #340