Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to API route /iot/groups (/iot/services still supported) #342

Merged
merged 7 commits into from
Aug 28, 2024

Conversation

mapedraza
Copy link
Collaborator

@mapedraza mapedraza commented Aug 27, 2024

This PR fix #270
This PR overpass #340

  • Tests
  • Code
  • Doc

@mapedraza mapedraza changed the title Add support to API route /iot/groups (/iot/services still supported) [WIP] Add support to API route /iot/groups (/iot/services still supported) Aug 27, 2024
@coveralls
Copy link

coveralls commented Aug 27, 2024

Pull Request Test Coverage Report for Build 10580644434

Details

  • 26 of 29 (89.66%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 76.205%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/services/iotaRedirector.js 11 14 78.57%
Files with Coverage Reduction New Missed Lines %
lib/services/iotaRedirector.js 3 79.07%
Totals Coverage Status
Change from base Build 9463456380: 0.0%
Covered Lines: 545
Relevant Lines: 677

💛 - Coveralls

@mapedraza mapedraza changed the title [WIP] Add support to API route /iot/groups (/iot/services still supported) Add support to API route /iot/groups (/iot/services still supported) Aug 27, 2024
@mapedraza mapedraza requested a review from AlvaroVega August 27, 2024 09:56
README.md Outdated Show resolved Hide resolved
Co-authored-by: Fermín Galán Márquez <[email protected]>
CHANGES_NEXT_RELEASE Outdated Show resolved Hide resolved
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Passing ball to @AlvaroVega for additional LGTM before merging.

Copy link
Member

@AlvaroVega AlvaroVega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlvaroVega AlvaroVega merged commit 21f9cfd into master Aug 28, 2024
6 checks passed
@AlvaroVega AlvaroVega deleted the task/add-groups-support-conservative branch August 28, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add /iot/groups routes to manager
4 participants