[TEST]: Improvement: Switch: New interaction approach #5759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkazlenka
requested changes
Dec 13, 2024
...ional-tests/src/main/groovy/org/openkilda/functionaltests/helpers/factory/FlowFactory.groovy
Show resolved
Hide resolved
...tional-tests/src/main/groovy/org/openkilda/functionaltests/helpers/model/PortExtended.groovy
Outdated
Show resolved
Hide resolved
...tional-tests/src/main/groovy/org/openkilda/functionaltests/helpers/model/PortExtended.groovy
Show resolved
Hide resolved
...tional-tests/src/main/groovy/org/openkilda/functionaltests/helpers/model/PortExtended.groovy
Outdated
Show resolved
Hide resolved
...tional-tests/src/main/groovy/org/openkilda/functionaltests/helpers/model/PortExtended.groovy
Outdated
Show resolved
Hide resolved
...ctional-tests/src/main/groovy/org/openkilda/functionaltests/helpers/model/SwitchRules.groovy
Outdated
Show resolved
Hide resolved
...al-tests/src/test/groovy/org/openkilda/functionaltests/spec/switches/DefaultRulesSpec.groovy
Outdated
Show resolved
Hide resolved
...al-tests/src/test/groovy/org/openkilda/functionaltests/spec/switches/DefaultRulesSpec.groovy
Outdated
Show resolved
Hide resolved
...al-tests/src/test/groovy/org/openkilda/functionaltests/spec/switches/DefaultRulesSpec.groovy
Outdated
Show resolved
Hide resolved
...ctional-tests/src/test/groovy/org/openkilda/functionaltests/spec/switches/LagPortSpec.groovy
Outdated
Show resolved
Hide resolved
yuliiamir
commented
Dec 13, 2024
| logicalPortNumber == lagPort | ||
| name == "novi_lport" + lagPort.toString() | ||
| portNumbers.sort() == portsArrayCreate.sort() | ||
| type == LogicalPortType.LAG | ||
| } | ||
|
|
||
| and: "Switch is valid" | ||
| !switchHelper.synchronizeAndCollectFixedDiscrepancies(sw.dpId).isPresent() | ||
| !switchToInteract.validateAndCollectFoundDiscrepancies().isPresent() |
There was a problem hiding this comment.
replaced with the validation call as sync doesn't check lag/group(the same below)
| country: initConf.location.country ?: "", | ||
| street: initConf.location.street ?: "" | ||
| ]] as SwitchPatchDto)}) | ||
| def response = northboundV2.partialSwitchUpdate(sw.dpId, updateRequest) |
There was a problem hiding this comment.
partialUpdate method has a rollback to the initial config(cleanupManger action)
...nal-tests/src/main/groovy/org/openkilda/functionaltests/helpers/factory/SwitchFactory.groovy
Outdated
Show resolved
Hide resolved
yuliiamir
force-pushed
the
test/improvement-switch-interaction
branch
from
5dc4fe8 to
8275508
Compare
yuliiamir
commented
Dec 30, 2024
| def "Unable decrease bandwidth on LAG port lower than connected flows bandwidth sum"() { | ||
| given: "Flows on a LAG port with switch ports" | ||
| def switchPair = switchPairs.all().random() | ||
| def testPorts = topology.getAllowedPortsForSwitch(switchPair.src).takeRight(2).sort() | ||
| def switchPair = switchPairs.all().withoutWBSwitch().random() |
There was a problem hiding this comment.
flaky test: excluded WB switch due to the difference in ports speed
yuliiamir
force-pushed
the
test/improvement-switch-interaction
branch
from
8275508 to
2ff4775
Compare
pkazlenka
approved these changes
Jan 3, 2025
...ional-tests/src/main/groovy/org/openkilda/functionaltests/helpers/factory/FlowFactory.groovy
Show resolved
Hide resolved
yuliiamir
force-pushed
the
test/improvement-switch-interaction
branch
5 times, most recently
from
c5758c8 to
a65ed7b
Compare
yuliiamir
force-pushed
the
test/improvement-switch-interaction
branch
2 times, most recently
from
dfbaf49 to
cd9c42b
Compare
pablomuri
approved these changes
Jan 28, 2025
| @@ -0,0 +1,33 @@ | |||
| /* Copyright 2021 Telstra Open Source | |||
There was a problem hiding this comment.
Please, update copyright
IvanChupin
approved these changes
Jan 29, 2025
yuliiamir
force-pushed
the
test/improvement-switch-interaction
branch
from
cd9c42b to
ce481bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the scope of
Global refactoring: Replace helpers with business models, new changes have been added. All interactions with a switch are available through the SwitchExtended business model. To not overload SwitchExtended by methods, it was decided to have separate modules for rules, meters, and lag interactions (reused existing entities SwitchRules and SwitchMeters).